Convert AzureEventHub and ConsumerGroup to Resources#7438
Merged
eerhardt merged 3 commits intomicrosoft:mainfrom Feb 6, 2025
Merged
Convert AzureEventHub and ConsumerGroup to Resources#7438eerhardt merged 3 commits intomicrosoft:mainfrom
eerhardt merged 3 commits intomicrosoft:mainfrom
Conversation
davidfowl
approved these changes
Feb 6, 2025
3 tasks
This allows them to be referenceable and waitable in the future. Also rename the classes and put them in the appropriate namespace. Contributes to microsoft#7407
… that can be chained.
eerhardt
force-pushed
the
EventHubsResources
branch
from
4874882 to
aba729c
Compare
eerhardt
added a commit
to eerhardt/aspire
that referenced
this pull request
Feb 7, 2025
…rGroup keys With microsoft#7438, EventHub Hub and Consumer Groups are Aspire Resources now, which means they can be referenced via WithReference. In the future, the EventHubs Host integration will append these values to the connection string. This will allow the hub and consumer group names to be specified outside of the application. (Today they are hard-coded in both, or specified separately in config.) When they flow through the connection string, the EventHubName and ConsumerGroup properties are populated on the settings object. Contributes to microsoft#7407
This was referenced Feb 7, 2025
davidfowl
added a commit
that referenced
this pull request
Feb 7, 2025
…rGroup keys (#7453) * Allow EventHub connection strings to work with EntityPath and ConsumerGroup keys With #7438, EventHub Hub and Consumer Groups are Aspire Resources now, which means they can be referenced via WithReference. In the future, the EventHubs Host integration will append these values to the connection string. This will allow the hub and consumer group names to be specified outside of the application. (Today they are hard-coded in both, or specified separately in config.) When they flow through the connection string, the EventHubName and ConsumerGroup properties are populated on the settings object. Contributes to #7407 * Apply suggestions from code review --------- Co-authored-by: David Fowler <davidfowl@gmail.com>
github-actions
Bot
added
the
area-integrations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This allows them to be referenceable and waitable in the future.
Also rename the classes and put them in the appropriate namespace.
Probably easiest to review each commit separately.
Contributes to #7407
Checklist
<remarks />and<code />elements on your triple slash comments?