Skip to content

Indenting in notification service logging#7449

Merged
davidfowl merged 2 commits intomainfrom
jamesnk/notificationservice-logging
Feb 7, 2025
Merged

Indenting in notification service logging#7449
davidfowl merged 2 commits intomainfrom
jamesnk/notificationservice-logging

Conversation

@JamesNK
Copy link
Copy Markdown
Member

@JamesNK JamesNK commented Feb 7, 2025

Description

Make resource notification logs easier to read.

After:

Version: 9
Resource dependentresource/dependentresource-fjjytbyn update published:
ResourceType = Container,
CreationTimeStamp = 2025-02-07T01:23:24,
State = { Text = Running, Style = (null) },
HeathStatus = Unhealthy,
ResourceReady = False,
ExitCode = (null),
Urls = {  },
EnvironmentVariables = {
  DIR = 
  PATH = /usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
  QDRANT__SERVICE__API_KEY = HnY0XayDT1be2qDQDQvnvD
  RUN_MODE = production
  TZ = Etc/UTC
},
Properties = {
  container.image = netaspireci.azurecr.io/qdrant/qdrant:v1.12.1
  container.id = 38432920bc1ddece9b223d8159c90cf629607db2240af7ce47b778aac83e3385
  container.command = (null)
  container.args = ./entrypoint.sh
  container.ports = 6334, 6333
  container.lifetime = Session
  resource.appArgs = (null)
  resource.appArgsSensitivity = (null)
},
HealthReports = {
  dependentresource_check = (null)
}

@JamesNK JamesNK added the area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication label Feb 7, 2025
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Comment thread src/Aspire.Hosting/ApplicationModel/ResourceNotificationService.cs Outdated
…e.cs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@davidfowl davidfowl merged commit d3dc64c into main Feb 7, 2025
@davidfowl davidfowl deleted the jamesnk/notificationservice-logging branch February 7, 2025 02:02
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants