Fix persistent lifetime support for Azure Event Hubs emulator#7467
Merged
Fix persistent lifetime support for Azure Event Hubs emulator#7467
Conversation
davidfowl
reviewed
Feb 7, 2025
Co-authored-by: David Fowler <davidfowl@gmail.com>
davidfowl
approved these changes
Feb 7, 2025
Contributor
|
Do these tests properly verify that the container is persistent? I expected to see something more functional testy |
eerhardt
reviewed
Feb 7, 2025
| var storageResource = builder.ApplicationBuilder | ||
| .AddAzureStorage($"{builder.Resource.Name}-storage") | ||
| .WithParentRelationship(builder.Resource) | ||
| .RunAsEmulator(); |
Member
There was a problem hiding this comment.
Is it possible to keep the RunAsEmulator() call close to where the storage resource is declared? It feels really far away now.
Member
There was a problem hiding this comment.
Maybe what might help is moving the Health Check code to the bottom of the method - like it is for ServiceBus.
eerhardt
approved these changes
Feb 7, 2025
Member
eerhardt
left a comment
eerhardt
left a comment
There was a problem hiding this comment.
Change looks good. I had a nit.
I also agree that we should have a test that verifies this (somehow).
Contributor
|
Conflict 😄 |
github-actions
Bot
added
the
area-integrations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Using the new Aspire Store and applying the same patterns for Config.json as with Azure Service Bus.
Checklist
<remarks />and<code />elements on your triple slash comments?breaking-changetemplate):doc-ideatemplate):