Skip to content

Obsolete DockerBuildArg and related APIs#7485

Merged
DamianEdwards merged 1 commit intomainfrom
davidfowl/publishas-dockerfile-overload-obsolete
Feb 8, 2025
Merged

Obsolete DockerBuildArg and related APIs#7485
DamianEdwards merged 1 commit intomainfrom
davidfowl/publishas-dockerfile-overload-obsolete

Conversation

@davidfowl
Copy link
Copy Markdown
Contributor

@davidfowl davidfowl commented Feb 8, 2025

Description

  • Obsolete DockerBuildArg and PublishAsDockerFile overload that takes it.
  • We no longer produce dockerfile.v0 resources. We favor container.v1 in all cases.

From https://github.com/dotnet/aspire/pull/7374/files#r1938826837

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • No
  • Did you add public API?
    • No
  • Does the change make any security assumptions or guarantees?
    • No
  • Does the change require an update in our Aspire docs?

- Obsolete DockerBuildArg and PublishAsDockerFile overload that takes it.
- We no longer produce dockerfile.v0 resources. We favor container.v1 in all cases.
@DamianEdwards DamianEdwards merged commit 26e35ad into main Feb 8, 2025
@DamianEdwards DamianEdwards deleted the davidfowl/publishas-dockerfile-overload-obsolete branch February 8, 2025 19:36
@github-actions github-actions Bot added the area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication label Mar 10, 2025
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants