Skip to content

Clear console logs from settings dialog#7490

Merged
JamesNK merged 6 commits intomainfrom
jamesnk/console-logs-settings-clear
Feb 10, 2025
Merged

Clear console logs from settings dialog#7490
JamesNK merged 6 commits intomainfrom
jamesnk/console-logs-settings-clear

Conversation

@JamesNK
Copy link
Copy Markdown
Member

@JamesNK JamesNK commented Feb 9, 2025

Description

console-logs-settings-clear

Fixes #7488

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 7 out of 22 changed files in this pull request and generated 1 comment.

Files not reviewed (15)
  • src/Aspire.Dashboard/Resources/Dialogs.Designer.cs: Language not supported
  • src/Aspire.Dashboard/Resources/Dialogs.resx: Language not supported
  • src/Aspire.Dashboard/Resources/xlf/Dialogs.cs.xlf: Language not supported
  • src/Aspire.Dashboard/Resources/xlf/Dialogs.de.xlf: Language not supported
  • src/Aspire.Dashboard/Resources/xlf/Dialogs.es.xlf: Language not supported
  • src/Aspire.Dashboard/Resources/xlf/Dialogs.fr.xlf: Language not supported
  • src/Aspire.Dashboard/Resources/xlf/Dialogs.it.xlf: Language not supported
  • src/Aspire.Dashboard/Resources/xlf/Dialogs.ja.xlf: Language not supported
  • src/Aspire.Dashboard/Resources/xlf/Dialogs.ko.xlf: Language not supported
  • src/Aspire.Dashboard/Resources/xlf/Dialogs.pl.xlf: Language not supported
  • src/Aspire.Dashboard/Resources/xlf/Dialogs.pt-BR.xlf: Language not supported
  • src/Aspire.Dashboard/Resources/xlf/Dialogs.ru.xlf: Language not supported
  • src/Aspire.Dashboard/Resources/xlf/Dialogs.tr.xlf: Language not supported
  • src/Aspire.Dashboard/Resources/xlf/Dialogs.zh-Hans.xlf: Language not supported
  • src/Aspire.Dashboard/Components/Dialogs/SettingsDialog.razor: Evaluated as low risk

Comment thread src/Aspire.Dashboard/Model/ConsoleLogsFilters.cs
Comment thread src/Aspire.Dashboard/Model/ConsoleLogsManager.cs Outdated
@JamesNK JamesNK force-pushed the jamesnk/console-logs-settings-clear branch from ed225f1 to 6e81442 Compare February 10, 2025 01:03
@JamesNK JamesNK merged commit 8c71a85 into main Feb 10, 2025
@JamesNK JamesNK deleted the jamesnk/console-logs-settings-clear branch February 10, 2025 01:22
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clear all button in settings should clear console logs

3 participants