Skip to content

Display launchSettings.json args in dashboard#7497

Merged
JamesNK merged 4 commits intomainfrom
jamesnk/display-launchsettings-args
Feb 11, 2025
Merged

Display launchSettings.json args in dashboard#7497
JamesNK merged 4 commits intomainfrom
jamesnk/display-launchsettings-args

Conversation

@JamesNK
Copy link
Copy Markdown
Member

@JamesNK JamesNK commented Feb 10, 2025

Description

Fixes #7475

Before (no args in dashboard):

image

After:

image

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?

@JamesNK JamesNK added the area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication label Feb 10, 2025
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

src/Aspire.Hosting/Dcp/DcpExecutor.cs:978

  • [nitpick] The variable name 'launchArgs' is not very descriptive. Consider renaming it to 'launchProfileArgs'.
var launchArgs = new List<(string Value, bool IsSensitive)>();

@JamesNK JamesNK requested a review from mitchdenny as a code owner February 10, 2025 03:19
Comment thread src/Aspire.Hosting/Dcp/DcpExecutor.cs
Comment thread src/Aspire.Hosting/Dcp/DcpExecutor.cs Outdated
@JamesNK JamesNK merged commit bb03224 into main Feb 11, 2025
@JamesNK JamesNK deleted the jamesnk/display-launchsettings-args branch February 11, 2025 07:34
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Launch profile args not displayed in dashboard

3 participants