Skip to content

Don't add relationship to parent with WaitFor#7498

Merged
JamesNK merged 2 commits intomainfrom
jamesnk/waitfor-relationship
Feb 10, 2025
Merged

Don't add relationship to parent with WaitFor#7498
JamesNK merged 2 commits intomainfrom
jamesnk/waitfor-relationship

Conversation

@JamesNK
Copy link
Copy Markdown
Member

@JamesNK JamesNK commented Feb 10, 2025

Description

WaitFor on a child resource automatically added a WaitFor relationship to the parent. This shows up in resource references/back references and is messy/confusing because the user didn't choose to do this.

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?

@JamesNK JamesNK added the area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication label Feb 10, 2025
@JamesNK JamesNK requested a review from mitchdenny as a code owner February 10, 2025 06:21
@JamesNK JamesNK merged commit b84baf9 into main Feb 10, 2025
@JamesNK JamesNK deleted the jamesnk/waitfor-relationship branch February 10, 2025 06:51
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants