Support comments in user secrets#7507
Merged
davidfowl merged 1 commit intomicrosoft:mainfrom Feb 11, 2025
Merged
Conversation
Signed-off-by: Cethric <7356786+cethric@users.noreply.github.com>
davidfowl
approved these changes
Feb 10, 2025
|
|
||
| private static async Task<JsonObject> GetUserSecretsAsync(string? userSecretsPath, CancellationToken cancellationToken) | ||
| { | ||
| var jsonDocumentOptions = new JsonDocumentOptions |
Contributor
There was a problem hiding this comment.
nit: I know that JsonSerializerOptions should be static, maybe this one should be too. At least if it can it wouldn't hurt.
Member
There was a problem hiding this comment.
JsonDocumentOptions is a struct and only contains an int, a bool, and an enum. It doesn't cache things like JsonSerializerOptions does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This solution takes inspiration from JsonConfigurationFileParser.cs in runtime to skip comments in the user secrets json file.
Completing this as a
good first issuebefore trying to work on something larger.Fixes #3284
Checklist
<remarks />and<code />elements on your triple slash comments?breaking-changetemplate):doc-ideatemplate):