Skip to content

Fix dashboard formatting tests#7526

Merged
JamesNK merged 3 commits intomainfrom
jamesnk/fix-formatting-tests
Feb 11, 2025
Merged

Fix dashboard formatting tests#7526
JamesNK merged 3 commits intomainfrom
jamesnk/fix-formatting-tests

Conversation

@JamesNK
Copy link
Copy Markdown
Member

@JamesNK JamesNK commented Feb 11, 2025

Description

.NET adds a non-breaking space character before AM/PM. Expected strings for dates in tests use a regular space. Most most cultures accept the whitespace difference, but I'm guessing GHA's uses a culture that doesn't (invariant?).

The fix is to ignore whitespace differences in the impacted asserts.

Fixes #7433

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?

@JamesNK JamesNK changed the title WIP Fix dashboard formatting tests Fix dashboard formatting tests Feb 11, 2025
@JamesNK JamesNK marked this pull request as ready for review February 11, 2025 07:49
@JamesNK JamesNK merged commit ad18db0 into main Feb 11, 2025
@JamesNK JamesNK deleted the jamesnk/fix-formatting-tests branch February 11, 2025 08:43
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Test] Fix dashboard tests on GitHub Actions

2 participants