[release/9.1] Require resource group on existing azure resources#7734
Merged
wtgodbe merged 2 commits intorelease/9.1from Feb 21, 2025
Merged
[release/9.1] Require resource group on existing azure resources#7734wtgodbe merged 2 commits intorelease/9.1from
wtgodbe merged 2 commits intorelease/9.1from
Conversation
Since, by default, publishing a .NET Asipre app will create a new resource group, not specifying a resource group won't work - since the current resource group hasn't been created yet. Because of this, require callers to explicitly specify the resource group to use. They can still say `null` to mean "use the current" if that's really what they want.
github-actions
Bot
force-pushed
the
backport/pr-7733-to-release/9.1
branch
from
5f6ca84 to
6fd9109
Compare
eerhardt
approved these changes
Feb 21, 2025
mitchdenny
approved these changes
Feb 21, 2025
github-actions
Bot
added
the
area-app-model
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #7733 to release/9.1
/cc @eerhardt
Customer Impact
It was pointed out that PublishAsExisting without a resource group is kinda pointless by default since we are creating a new resource group the first time you deploy. Changing the method signature to require a resource group, which sets up the caller to be more likely to succeed.
Since this is an API change, we need to make it before we ship 9.1 stable, or else we need to live with the current API.
Testing
Existing tests in the repo. No functional differences, we just require the parameter to be specified now.
Risk
No real risk. Just dropping a default parameter.
Regression?
No.