Update reconnection E2E tests #12372
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiercn
approved these changes
Jul 19, 2019
Member
javiercn
left a comment
javiercn
left a comment
There was a problem hiding this comment.
I assume this just fix the test.
Member
Author
|
That’s right. |
pranavkm
approved these changes
Jul 19, 2019
Member
|
Merging this because it's currently 4:18am in the UK (I assume) and steve is a asleep (or at a warehouse rave) |
ghost
deleted the
Member
Author
|
Yes, another warehouse rave as usual. Thanks for merging. |
mkArtakMSFT
added
the
tell-mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was too hasty when merging #12361. There was still a commit to go for updating the E2E tests. It's here now.