-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Revert multiple SDK updates. #33920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert multiple SDK updates. #33920
Conversation
I'm still trying to figure out what the problem is and how to fix the internal build issues, but I want to have this ready as a backup if the fix is non-trivial. |
This already passed an internal build https://dev.azure.com/dnceng/internal/_build/results?buildId=1209830&view=results |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In case we don't have other alternatives identified, we can check this in.
} | ||
|
||
// Temporary while investigating why this process occasionally never runs or exits on Debian 9 | ||
environmentVariables.Add("COREHOST_TRACE", "1"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remember to revert this if you end up checking this in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume the internal build issues are unrelated to the source generator change?
I assume the internal build issues are unrelated to any source gen stuff. We consistently see the following error when publishing successfully built assets.
|
@captainsafia see Teams conversation in Build channel. @halter73 is going back two SDK updates (your #33833 and @BrennanConroy's #33719) to get back to a known-good state while we let those w/ actual knowledge e.g. @rainersigwald @MattGal figure things out. |
Yep. Sounds good.
I'm working on tracking down this one. |
Closing in favor of #33922 |
This seems to fix multiple internal builds and avoids the following error when building in VS.