Skip to content

Conversation

halter73
Copy link
Member

This seems to fix multiple internal builds and avoids the following error when building in VS.

Error    CS8032    An instance of analyzer Microsoft.NET.Sdk.Razor.SourceGenerators.RazorSourceGenerator cannot be created from C:\github\aspnetcore\.dotnet\sdk\6.0.100-preview.7.21327.2\Sdks\Microsoft.NET.Sdk.Razor\source-generators\Microsoft.NET.Sdk.Razor.SourceGenerators.dll : Could not load type 'Microsoft.CodeAnalysis.IIncrementalGenerator' from assembly 'Microsoft.CodeAnalysis, Version=4.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35'

@halter73 halter73 requested review from a team and Pilchie as code owners June 28, 2021 20:37
@halter73
Copy link
Member Author

I'm still trying to figure out what the problem is and how to fix the internal build issues, but I want to have this ready as a backup if the fix is non-trivial.

@halter73
Copy link
Member Author

This already passed an internal build https://dev.azure.com/dnceng/internal/_build/results?buildId=1209830&view=results

Copy link
Contributor

@JunTaoLuo JunTaoLuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In case we don't have other alternatives identified, we can check this in.

}

// Temporary while investigating why this process occasionally never runs or exits on Debian 9
environmentVariables.Add("COREHOST_TRACE", "1");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember to revert this if you end up checking this in.

Copy link
Member

@captainsafia captainsafia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume the internal build issues are unrelated to the source generator change?

@halter73
Copy link
Member Author

I assume the internal build issues are unrelated to any source gen stuff. We consistently see the following error when publishing successfully built assets.

BARBuildId : The term 'BARBuildId' is not recognized as the name of a cmdlet, function, script file, or operable program.

@dougbu
Copy link
Contributor

dougbu commented Jun 28, 2021

@captainsafia see Teams conversation in Build channel. @halter73 is going back two SDK updates (your #33833 and @BrennanConroy's #33719) to get back to a known-good state while we let those w/ actual knowledge e.g. @rainersigwald @MattGal figure things out.

@captainsafia
Copy link
Member

Yep. Sounds good.

avoids the following error when building in VS.

I'm working on tracking down this one.

@halter73
Copy link
Member Author

Closing in favor of #33922

@halter73 halter73 closed this Jun 28, 2021
@halter73 halter73 deleted the halter73/test-old-sdk branch June 28, 2021 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants