Revert to last known good SDK #33922
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The real fix for the internal build appears to be dotnet/sdk#18526, but that hasn't merged into main yet, so I'm not sure we should wait. |
It can removed in Wasm.Performance.TestApp.csproj but kept in BasicTestApp.csproj. |
halter73
commented
Jun 28, 2021
src/Components/benchmarkapps/Wasm.Performance/TestApp/Wasm.Performance.TestApp.csproj
Outdated
Show resolved
Hide resolved
…formance.TestApp.csproj
1 task
Pilchie
approved these changes
Jun 28, 2021
ghost
added this to the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This undoes less than #33920, so I plan to merge this instead of the internal build passes.
@captainsafia Should I still be adding the
<UseRazorSourceGenerator>false</UseRazorSourceGenerator>back?