Skip to content

Fix : ComplexObjectModelBinder throws error when creating instance for positional records that inherit positional record #31077 #34618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pranavkm merged 1 commit into from
Jul 22, 2021
Merged

Fix : ComplexObjectModelBinder throws error when creating instance for positional records that inherit positional record #31077 #34618

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Mvc/Mvc.Core/src/ModelBinding/Metadata/DefaultBindingMetadataProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ static bool IsRecordType(Type type)
{
// Based on the state of the art as described in https://github.com/dotnet/roslyn/issues/45777
var cloneMethod = type.GetMethod("<Clone>$", BindingFlags.Public | BindingFlags.Instance);
return cloneMethod != null && cloneMethod.ReturnType == type;
return cloneMethod != null && (cloneMethod.ReturnType == type || cloneMethod.ReturnType == type.BaseType);
}
}

Expand Down
20 changes: 20 additions & 0 deletions src/Mvc/Mvc.Core/test/ModelBinding/Metadata/DefaultBindingMetadataProviderTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -798,6 +798,26 @@ public void GetBoundConstructor_ReturnsNull_ForRecordTypeWithMultipleConstructor
Assert.Null(result);
}

[Fact]
public void GetBoundConstructor_ReturnsPrimaryConstructor_ForRecordTypeInherited()
{
// Arrange
var type = typeof(Model);

// Act
var result = DefaultBindingMetadataProvider.GetBoundConstructor(type);

// Assert
Assert.NotNull(result);
Assert.Collection(
result.GetParameters(),
p => Assert.Equal("Name", p.Name),
p => Assert.Equal("Value", p.Name));
}

public record BaseModel(int Value);
public record Model(string Name, int Value) : BaseModel(Value);

private record RecordTypeWithConformingSynthesizedConstructor
{
public RecordTypeWithConformingSynthesizedConstructor(string Name, int Age)
Expand Down