Add support for building 2.1 Razor projects using the RazorSDK #35121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-mvc
This is a port of dotnet/sdk#19094 to 5.0 that changes the RazorSDK to use the in-box compiler when building 2.1 apps.
pranavkm
force-pushed
the
prkrishn/21-compiler
branch
from
cd9ba96 to
8d8431a
Compare
Contributor
Author
|
Port of dotnet/razor#4038 for 5.0 |
mkArtakMSFT
approved these changes
Aug 7, 2021
Member
|
Can we update the milestone of this to indicate where it's shipping? I expect that 's 5.0.11 |
Contributor
|
Moved this to 5.0.11, as this has missed the September release train. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a port of dotnet/sdk#19094 to 5.0 that changes the RazorSDK to use the in-box
compiler when building 2.1 apps.
Description
2.1 shipped a Razor compiler as a package which was referenced by ASP.NET Core MVC apps by default. This package contained a 2.1 binary that required the 2.1 .NET runtime. As part of our 2.1 EOL work, we updated the 6.0 SDK to instead use the Razor compiler that is carried in the SDK. This PR ports the change to the 5.0 Razor SDK.
Customer Impact
Our 6.0 verification confirmed that the compiler in the SDK is highly compatible with the 2.1 compiler and users should be able to upgrade without issues.
Regression?
[If yes, specify the version the behavior has regressed from]
Risk
While we performed manual testing and have automated test to cover this scenario, it's possible there are some scenarios that the compiler's behavior has changed since 2.1 that isn't easily evident through our testing.
Verification
Packaging changes reviewed?
Addresses #35118