Skip to content

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Nov 4, 2021

Backport of #38045 to release/6.0

/cc @halter73

Improve exception messages referencing startup code

Description

Old exception messages referred to "ConfigureServices(...)" and "Configure(...)" methods from Startup.cs which no longer exists in the new ASP.NET project templates. This updates the exception messages to no longer reference these methods and instead refer more generically to "application startup code".

The issue was filed by @Rick-Anderson while updating docs for .NET 6

Fixes #37778

Customer Impact

The old exception messages could confuse developers by referencing methods that don't exist in their new .NET 6 projects.

Regression?

  • Yes
  • No

Prior to .NET 6, the methods referenced in the exception messages were far more likely to exist in your ASP.NET project.

Risk

  • High
  • Medium
  • Low

This only changes exception messages.

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

@ghost ghost added this to the 6.0.x milestone Nov 4, 2021
@ghost
Copy link

ghost commented Nov 4, 2021

Hi @github-actions[bot]. If this is not a tell-mode PR, please make sure to follow the instructions laid out in the servicing process document.
Otherwise, please add tell-mode label.

@halter73 halter73 added the area-auth Includes: Authn, Authz, OAuth, OIDC, Bearer label Nov 4, 2021
@halter73 halter73 force-pushed the backport/pr-38045-to-release/6.0 branch from 7d58e4c to 3fb735e Compare November 4, 2021 21:04
@halter73 halter73 added the Servicing-consider Shiproom approval is required for the issue label Nov 4, 2021
@ghost
Copy link

ghost commented Nov 4, 2021

Hi @github-actions[bot]. Please make sure you've updated the PR description to use the Shiproom Template. Also, make sure this PR is not marked as a draft and is ready-to-merge.

To learn more about how to prepare a servicing PR click here.

@halter73 halter73 changed the title [release/6.0] Improve exception messages for missing auth services [release/6.0] Improve exception messages referencing startup code Nov 4, 2021
@leecow leecow added Servicing-approved Shiproom has approved the issue and removed Servicing-consider Shiproom approval is required for the issue labels Nov 9, 2021
@leecow leecow modified the milestones: 6.0.x, 6.0.1 Nov 9, 2021
@wtgodbe wtgodbe merged commit 291e10e into release/6.0 Nov 10, 2021
@wtgodbe wtgodbe deleted the backport/pr-38045-to-release/6.0 branch November 10, 2021 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-auth Includes: Authn, Authz, OAuth, OIDC, Bearer Servicing-approved Shiproom has approved the issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants