Ignore NullableContextAttribute on convention methods. #49287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
old-area-web-frameworks-do-not-use
mitchdenny
removed
the
old-area-web-frameworks-do-not-use
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
| attribute is ProducesDefaultResponseTypeAttribute || | ||
| attribute is ApiConventionNameMatchAttribute; | ||
| attribute is ApiConventionNameMatchAttribute || | ||
| attribute.GetType().FullName == "System.Runtime.CompilerServices.NullableContextAttribute"; |
There was a problem hiding this comment.
Suggested change
| attribute.GetType().FullName == "System.Runtime.CompilerServices.NullableContextAttribute"; | |
| attribute.GetType().FullName == "System.Runtime.CompilerServices.NullableContextAttribute"; |
Is there a reason we can't do attribute is NullableContextAttribute here?
There was a problem hiding this comment.
NullableContextAttribute is a compiler code spit into the users code, example from SharpLab:
https://sharplab.io/#v2:EYLgtghglgdgNAExAagD4AEAsACAYge3wAoAhCAJwH5tgBKAWACgBvJgXyafQCZszymrRh0ZA===
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
captainsafia
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17761
Developers don't have a choice as to whether the
NullableContextAttributeis emitted and decorates their method, it's a side effect of the arguments. This adds logic to ignore that attribute when considering whether a convention method is valid or not.