Skip to content

Conversation

@gero3
Copy link
Contributor

@gero3 gero3 commented Jul 26, 2023

Only compare the defaultserveraddress once in test

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Only compare the defaultserveraddress once in test

Description

A previous commit made it so defaultserveraddress got checked twice for no reason. Before it got checked for https too but this got deleted by the following commit. Which made the comparision the same.

Fixes #49645

Previously it got checked for https too but this got deleted by the following [commit](dotnet@86e28e7#diff-5941cc1785b7940041bb2291919eff8cb327fb1535128e87197ac0f79817cb62L531)
@ghost ghost added area-runtime community-contribution Indicates that the PR has been added by a community member labels Jul 26, 2023
@ghost
Copy link

ghost commented Jul 26, 2023

Thanks for your PR, @gero3. Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

Copy link
Member

@Tratcher Tratcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Tratcher Tratcher merged commit f982851 into dotnet:main Jul 26, 2023
@ghost ghost added this to the 8.0-rc1 milestone Jul 26, 2023
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cleanup duplicate code in src/Servers/Kestrel/test/BindTests/AddressRegistrationTests.cs

3 participants