[Blazor] Pass the member info directly #53874
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
MackinnonBuck
approved these changes
Feb 7, 2024
javiercn
force-pushed
the
javiercn/issue52755
branch
from
0756e42 to
bdccb3a
Compare
SteveSandersonMS
approved these changes
Feb 8, 2024
Member
Author
|
/backport to release/8.0 |
Contributor
|
Started backporting to release/8.0: https://github.com/dotnet/aspnetcore/actions/runs/7829121848 |
11 tasks
1 task
onurmicoogullari
pushed a commit
to onurmicoogullari/aspnetcore
that referenced
this pull request
Feb 14, 2024
* Fixes an issue in `FieldIdentifier.Create` where we were using `PropertyOrField` and that was causing issues with members that just differed in casing and members with non ASCII characters. * We already had the `MemberInfo` that `PropertyOrField` needed to compute, so we stored that in the cache instead and used `MakeMemberAccess`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #52755
The code didn't handle multiple members that differed only in casing. Upon analysis of the implementation, we determined that we could rely on the already available
MemberInfoinstead of searching for it while building the expression.