Skip to content

Set status code on CreatedResult types #55494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 3, 2024
Merged

Set status code on CreatedResult types #55494

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/Mvc/Mvc.Core/src/CreatedResult.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,12 @@ public class CreatedResult : ObjectResult
private string? _location;

/// <summary>
/// Initializes a new instance of the <see cref="CreatedResult"/> class
/// </summary>
/// Initializes a new instance of the <see cref="CreatedResult"/> class
/// </summary>
public CreatedResult()
: base(null)
{
StatusCode = DefaultStatusCode;
}

/// <summary>
Expand Down
12 changes: 11 additions & 1 deletion src/Mvc/Mvc.Core/test/CreatedResultTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,16 @@ namespace Microsoft.AspNetCore.Mvc;

public class CreatedResultTests
{
[Fact]
public void CreatedResult_SetsStatusCode()
{
// Act
var result = new CreatedResult();

// Assert
Assert.Equal(StatusCodes.Status201Created, result.StatusCode);
}

[Fact]
public void CreatedResult_SetsLocation()
{
Expand Down Expand Up @@ -68,7 +78,7 @@ public async Task CreatedResult_ReturnsStatusCode_SetsLocationHeader()
[Fact]
public async Task CreatedResult_ReturnsStatusCode_NotSetLocationHeader()
{
// Arrange
// Arrange
var httpContext = GetHttpContext();
var actionContext = GetActionContext(httpContext);
var result = new CreatedResult((string)null, "testInput");
Expand Down