-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[SignalR] Add parameter index to invocation binding exception message #64016
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enhances SignalR's error reporting by adding parameter index information to invocation binding exception messages. When argument binding fails due to type mismatches, the error message now includes which specific argument caused the failure (e.g., "Error binding argument 1" instead of "Error binding arguments").
- Updates error message format across all SignalR protocol implementations to include argument index
- Modifies loop structures to track the current argument index for error reporting
- Updates corresponding test expectations to match the new error message format
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| MessagePackHubProtocolTestBase.cs | Updates test expectations for MessagePack protocol error messages to include argument index |
| JsonHubProtocolTestsBase.cs | Updates test expectations for JSON protocol error messages to include argument index |
| NewtonsoftJsonHubProtocol.cs | Modifies error handling to include parameter index in binding failure messages |
| MessagePackHubProtocolWorker.cs | Updates loop structure and error message to track and report argument index |
| JsonHubProtocol.cs | Adds parameter index to binding error messages |
| GsonHubProtocolTest.java | Updates Java client test expectations for new error message format |
| GsonHubProtocol.java | Implements argument index tracking in Java client protocol implementation |
| HubConnectionTests.cs | Updates functional test expectations for new error message format |
src/SignalR/clients/java/signalr/core/src/main/java/com/microsoft/signalr/GsonHubProtocol.java
Show resolved
Hide resolved
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
Looks like this PR hasn't been active for some time and the codebase could have been changed in the meantime. |
|
I was gonna ask if we have any names 😄 |
Updates how argument binding errors are reported to include which argument caused the binding failure, making it easier to diagnose issues when types do not match.
Finally able to get rid of a sticky note I've had on my desk for >3 years.