Fix shared code policy triggering on PRs with zero file changes #64407
+9
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs-area-label
Member
Author
|
@wtgodbe PTAL |
adityamandaleeka
added
area-infrastructure
Copilot finished reviewing on behalf of
adityamandaleeka
November 17, 2025 23:12
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the shared code policy configuration where the policy was incorrectly triggering on pull requests with zero file changes. The root cause was an unnecessary or: wrapper around a single includesModifiedFiles condition, which likely caused the condition to always evaluate to true when a PR was opened.
- Removed the unnecessary
or:wrapper from the shared code policy condition - Cleaned up trailing whitespace on several lines
wtgodbe
approved these changes
Nov 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The shared code policy in resourceManagement.yml was incorrectly triggering on pull requests that had zero file changes (most noticeable in Copilot PRs which are initially empty).
I'm not 100% sure but I think this is caused by an unnecessary
or:wrapper around a singleincludesModifiedFilescondition. Let's see if this fixes it.