Skip to content

Add loopback addresses to the development certificate #64431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 19, 2025
+5 −2
Merged

Add loopback addresses to the development certificate #64431

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
597f66d
Add loopback addresses to development certificate
danegsta Nov 18, 2025
eeb54ac
Add using statement
danegsta Nov 19, 2025
65e98ef
Delete src/Shared/Shared.sln
danegsta Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/Shared/CertificateGeneration/CertificateManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
using System.Diagnostics.CodeAnalysis;
using System.Diagnostics.Tracing;
using System.Linq;
using System.Net;
using System.Runtime.InteropServices;
using System.Security.Cryptography;
using System.Security.Cryptography.X509Certificates;
Expand All @@ -19,8 +20,8 @@ namespace Microsoft.AspNetCore.Certificates.Generation;

internal abstract class CertificateManager
{
internal const int CurrentAspNetCoreCertificateVersion = 5;
internal const int CurrentMinimumAspNetCoreCertificateVersion = 5;
internal const int CurrentAspNetCoreCertificateVersion = 6;
internal const int CurrentMinimumAspNetCoreCertificateVersion = 6;

// OID used for HTTPS certs
internal const string AspNetHttpsOid = "1.3.6.1.4.1.311.84.1.1";
Expand Down Expand Up @@ -697,6 +698,8 @@ internal X509Certificate2 CreateAspNetCoreHttpsDevelopmentCertificate(DateTimeOf
sanBuilder.AddDnsName(InternalWildcardHttpsDnsName);
sanBuilder.AddDnsName(LocalhostDockerHttpsDnsName);
sanBuilder.AddDnsName(ContainersDockerHttpsDnsName);
sanBuilder.AddIpAddress(IPAddress.Loopback);
sanBuilder.AddIpAddress(IPAddress.IPv6Loopback);

var keyUsage = new X509KeyUsageExtension(X509KeyUsageFlags.KeyEncipherment | X509KeyUsageFlags.DigitalSignature, critical: true);
var enhancedKeyUsage = new X509EnhancedKeyUsageExtension(
Expand Down
Loading