Align the summary with ToBaseRelativePath actual job
#64662
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilonatommy
added
Docs
Copilot finished reviewing on behalf of
ilonatommy
December 5, 2025 10:25
Contributor
There was a problem hiding this comment.
Pull request overview
This PR corrects misleading documentation for the ToAbsoluteUri method in NavigationManager. The original documentation incorrectly stated that the method resolves relative URIs "relative to the current absolute URI," when in fact the implementation resolves them relative to the base URI (typically from the <base> element). This fix addresses AI hallucinations caused by the inaccurate documentation.
- Updated XML documentation comment to accurately reflect the actual behavior of the
ToAbsoluteUrimethod
akoeplinger
approved these changes
Dec 5, 2025
javiercn
approved these changes
Dec 5, 2025
maraf
approved these changes
Dec 5, 2025
oroztocil
approved these changes
Dec 5, 2025
pavelsavara
approved these changes
Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In relation to #23615 (comment).
The doc summary is misleading and contributes to AI hallucinations.
"current absolute URI" is
NavigationManager._uriand the method uses
_baseUri, so "relative to the base URI" is more correct.