Prevent the ASP.NET certificate generation logic from running on the installers

Author: javiercn

src/Microsoft.DotNet.Configurer/NoOpAspNetCertificateSentinel.cs

@@ -0,0 +1,21 @@
+// Copyright (c) .NET Foundation and contributors. All rights reserved.
+// Licensed under the MIT license. See LICENSE file in the project root for full license information.
+
+namespace Microsoft.DotNet.Configurer
+{
+    public class NoOpAspNetCertificateSentinel : IAspNetCertificateSentinel
+    {
+        public bool Exists()
+        {
+            return true;
+        }
+
+        public void CreateIfNotExists()
+        {
+        }
+
+        public void Dispose()
+        {
+        }
+    }
+}

src/dotnet/Program.cs

@@ -92,6 +92,7 @@ internal static int ProcessArgs(string[] args, ITelemetry telemetryClient = null
                 new FirstTimeUseNoticeSentinel(cliFallbackFolderPathCalculator))
             {
                 IFirstTimeUseNoticeSentinel firstTimeUseNoticeSentinel = disposableFirstTimeUseNoticeSentinel;
+                IAspNetCertificateSentinel aspNetCertificateSentinel = new AspNetCertificateSentinel(cliFallbackFolderPathCalculator);
                 for (; lastArg < args.Length; lastArg++)
                 {
                     if (IsArg(args[lastArg], "d", "diagnostics"))
@@ -134,14 +135,15 @@ internal static int ProcessArgs(string[] args, ITelemetry telemetryClient = null
                         var hasSuperUserAccess = false;
                         if (IsDotnetBeingInvokedFromNativeInstaller(topLevelCommandParserResult))
                         {
+                            aspNetCertificateSentinel = new NoOpAspNetCertificateSentinel();
                             firstTimeUseNoticeSentinel = new NoOpFirstTimeUseNoticeSentinel();
                             hasSuperUserAccess = true;
                         }
 
                         ConfigureDotNetForFirstTimeUse(
                             nugetCacheSentinel,
                             firstTimeUseNoticeSentinel,
-                            new AspNetCertificateSentinel(cliFallbackFolderPathCalculator),
+                            aspNetCertificateSentinel,
                             cliFallbackFolderPathCalculator,
                             hasSuperUserAccess);
 

test/dotnet.Tests/GivenThatTheUserIsRunningDotNetForTheFirstTime.cs

@@ -76,6 +76,15 @@ public void ItShowsTheAppropriateMessageToTheUser()
                 .And.NotContain("Restore completed in");
         }
 
+        [Fact]
+        public void ItShowsTheAspNetCertificateGenerationMessageToTheUser()
+        {
+            _firstDotnetVerbUseCommandResult.StdOut
+                .Should()
+                .ContainVisuallySameFragment(Configurer.LocalizableStrings.AspNetCertificateInstalled)
+                .And.NotContain("Restore completed in");
+        }
+
         [Fact]
         public void ItCreatesASentinelFileUnderTheNuGetCacheFolder()
         {
@@ -93,7 +102,15 @@ public void ItCreatesAFirstUseSentinelFileUnderTheDotDotNetFolder()
         }
 
         [Fact]
-        public void ItDoesNotCreateAFirstUseSentinelFileUnderTheDotDotNetFolderWhenInternalReportInstallSuccessIsInvoked()
+        public void ItCreatesAnAspNetCertificateSentinelFileUnderTheDotDotNetFolder()
+        {
+            _dotDotnetFolder
+                .Should()
+                .HaveFile($"{GetDotnetVersion()}.aspNetCertificateSentinel");
+        }
+
+        [Fact]
+        public void ItDoesNotCreateAFirstUseSentinelFileNorAnAspNetCertificateSentinelFileUnderTheDotDotNetFolderWhenInternalReportInstallSuccessIsInvoked()
         {
             var emptyHome = Path.Combine(_testDirectory, "empty_home");
             var profiled = Path.Combine(_testDirectory, "profile.d");
@@ -117,6 +134,7 @@ public void ItDoesNotCreateAFirstUseSentinelFileUnderTheDotDotNetFolderWhenInter
             var homeFolder = new DirectoryInfo(Path.Combine(emptyHome, ".dotnet"));
             string[] fileEntries = Directory.GetFiles(homeFolder.ToString());
             fileEntries.Should().OnlyContain(x => !x.Contains(".dotnetFirstUseSentinel"));
+            fileEntries.Should().OnlyContain(x => !x.Contains(".aspNetCertificateSentinel"));
         }
 
         [Fact]
@@ -147,6 +165,34 @@ public void ItShowsTheTelemetryNoticeWhenInvokingACommandAfterInternalReportInst
                 .ContainVisuallySameFragment(Configurer.LocalizableStrings.FirstTimeWelcomeMessage);
         }
 
+        [Fact]
+        public void ItShowsTheAspNetCertificateGenerationMessageWhenInvokingACommandAfterInternalReportInstallSuccessHasBeenInvoked()
+        {
+            var newHome = Path.Combine(_testDirectory, "aspnet_home");
+            var newHomeFolder = new DirectoryInfo(Path.Combine(newHome, ".dotnet"));
+            var profiled = Path.Combine(_testDirectory, "profile.d");
+            var pathsd = Path.Combine(_testDirectory, "paths.d");
+
+            var command = new DotnetCommand()
+                .WithWorkingDirectory(_testDirectory);
+            command.Environment["HOME"] = newHome;
+            command.Environment["USERPROFILE"] = newHome;
+            command.Environment["APPDATA"] = newHome;
+            command.Environment["DOTNET_CLI_TEST_FALLBACKFOLDER"] = _nugetFallbackFolder.FullName;
+            command.Environment["DOTNET_CLI_TEST_LINUX_PROFILED_PATH"] = profiled;
+            command.Environment["DOTNET_CLI_TEST_OSX_PATHSD_PATH"] = pathsd;
+            command.Environment["DOTNET_SKIP_FIRST_TIME_EXPERIENCE"] = "";
+            command.Environment["SkipInvalidConfigurations"] = "true";
+
+            command.ExecuteWithCapturedOutput("internal-reportinstallsuccess test").Should().Pass();
+
+            var result = command.ExecuteWithCapturedOutput("new --debug:ephemeral-hive");
+
+            result.StdOut
+                .Should()
+                .ContainVisuallySameFragment(Configurer.LocalizableStrings.AspNetCertificateInstalled);
+        }
+
         [Fact]
         public void ItRestoresTheNuGetPackagesToTheNuGetCacheFolder()
         {