Use a multi-proc aware MSBuild logger (#8371)

Make use of the MSBuild distributed logger functionality and add a
forwarding logger. When in a multi-proc build, the forwarding logger
will decide which events to forward to the main node to be logged.
Without this, all events are routed and a perf penalty is incurred.

Author: AndyGerlicher

src/dotnet/commands/dotnet-msbuild/MSBuildForwardingApp.cs

@@ -28,11 +28,12 @@ private static IEnumerable<string> ConcatTelemetryLogger(IEnumerable<string> arg
                 try
                 {
                     Type loggerType = typeof(MSBuildLogger);
+                    Type forwardingLoggerType = typeof(MSBuildForwardingLogger);
 
                     return argsToForward
                         .Concat(new[]
                         {
-                            $"/Logger:{loggerType.FullName},{loggerType.GetTypeInfo().Assembly.Location}"
+                            $"/distributedlogger:{loggerType.FullName},{loggerType.GetTypeInfo().Assembly.Location}*{forwardingLoggerType.FullName},{forwardingLoggerType.GetTypeInfo().Assembly.Location}"
                         });
                 }
                 catch (Exception)

src/dotnet/commands/dotnet-msbuild/MSBuildForwardingLogger.cs

@@ -0,0 +1,36 @@
+// Copyright (c) .NET Foundation and contributors. All rights reserved.
+// Licensed under the MIT license. See LICENSE file in the project root for full license information.
+
+using Microsoft.Build.Framework;
+
+namespace Microsoft.DotNet.Tools.MSBuild
+{
+    public sealed class MSBuildForwardingLogger : IForwardingLogger
+    {
+        public LoggerVerbosity Verbosity { get; set; }
+
+        public string Parameters { get; set; }
+
+        public IEventRedirector BuildEventRedirector { get; set; }
+
+        public int NodeId { get; set; }
+
+        public void Initialize(IEventSource eventSource)
+        {
+            // Only forward telemetry events
+            if (eventSource is IEventSource2 eventSource2)
+            {
+                eventSource2.TelemetryLogged += (sender, args) => BuildEventRedirector.ForwardEvent(args);
+            }
+        }
+
+        public void Initialize(IEventSource eventSource, int nodeCount)
+        {
+            Initialize(eventSource);
+        }
+
+        public void Shutdown()
+        {
+        }
+    }
+}

src/dotnet/commands/dotnet-msbuild/MSBuildLogger.cs

@@ -11,7 +11,7 @@
 
 namespace Microsoft.DotNet.Tools.MSBuild
 {
-    public sealed class MSBuildLogger : Logger
+    public sealed class MSBuildLogger : INodeLogger
     {
         private readonly IFirstTimeUseNoticeSentinel _sentinel =
             new FirstTimeUseNoticeSentinel(new CliFolderPathCalculator());
@@ -38,7 +38,12 @@ public MSBuildLogger()
             }
         }
 
-        public override void Initialize(IEventSource eventSource)
+        public void Initialize(IEventSource eventSource, int nodeCount)
+        {
+            Initialize(eventSource);
+        }
+
+        public void Initialize(IEventSource eventSource)
         {
             try
             {
@@ -76,7 +81,7 @@ private void OnTelemetryLogged(object sender, TelemetryEventArgs args)
             FormatAndSend(_telemetry, args);
         }
 
-        public override void Shutdown()
+        public void Shutdown()
         {
             try
             {
@@ -86,8 +91,10 @@ public override void Shutdown()
             {
                 // Exceptions during telemetry shouldn't cause anything else to fail
             }
-
-            base.Shutdown();
         }
+
+        public LoggerVerbosity Verbosity { get; set; }
+
+        public string Parameters { get; set; }
     }
 }

test/dotnet-msbuild.Tests/GivenDotnetMSBuildBuildsProjects.cs

@@ -138,7 +138,7 @@ public void WhenTelemetryIsEnabledTheLoggerIsAddedToTheCommandLine()
                 allArgs.Should().NotBeNull();
 
                 allArgs.Should().Contain(
-                    value => value.IndexOf("/Logger", StringComparison.OrdinalIgnoreCase) >= 0,
+                    value => value.IndexOf("/distributedlogger", StringComparison.OrdinalIgnoreCase) >= 0,
                     "The MSBuild logger argument should be specified when telemetry is enabled.");
             }
         }