Make Sln.Internal.Tests pass on localized setup

Author: nguerrera

src/Microsoft.DotNet.Cli.Sln.Internal/Properties/AssemblyInfo.cs

@@ -0,0 +1,7 @@
+// Copyright (c) .NET Foundation and contributors. All rights reserved.
+// Licensed under the MIT license. See LICENSE file in the project root for full license information.
+
+using System.Reflection;
+using System.Runtime.CompilerServices;
+
+[assembly: InternalsVisibleTo("Microsoft.DotNet.Cli.Sln.Internal.Tests, PublicKey=0024000004800000940000000602000000240000525341310004000001000100039ac461fa5c82c7dd2557400c4fd4e9dcdf7ac47e3d572548c04cd4673e004916610f4ea5cbf86f2b1ca1cb824f2a7b3976afecfcf4eb72d9a899aa6786effa10c30399e6580ed848231fec48374e41b3acf8811931343fc2f73acf72dae745adbcb7063cc4b50550618383202875223fc75401351cd89c44bf9b50e7fa3796")]

test/Microsoft.DotNet.Cli.Sln.Internal.Tests/Microsoft.DotNet.Cli.Sln.Internal.Tests.cs

@@ -303,7 +303,7 @@ public void WhenGivenASolutionWithMissingHeaderVersionItThrows(string fileConten
             };
 
             action.ShouldThrow<InvalidSolutionFormatException>()
-                .WithMessage($"Invalid format in line {lineNum}: File header is missing version");
+                .WithMessage(FormatError(lineNum, LocalizableStrings.FileHeaderMissingVersionError));
         }
 
         [Theory]
@@ -321,7 +321,7 @@ public void WhenGivenASolutionWithMissingHeaderItThrows(string fileContents)
             };
 
             action.ShouldThrow<InvalidSolutionFormatException>()
-                .WithMessage("Expected file header not found");
+                .WithMessage(LocalizableStrings.FileHeaderMissingError);
         }
 
         [Fact]
@@ -343,7 +343,7 @@ public void WhenGivenASolutionWithMultipleGlobalSectionsItThrows()
             };
 
             action.ShouldThrow<InvalidSolutionFormatException>()
-                .WithMessage("Invalid format in line 5: Global section specified more than once");
+                .WithMessage(FormatError(5, LocalizableStrings.GlobalSectionMoreThanOnceError));
         }
 
         [Fact]
@@ -362,7 +362,7 @@ public void WhenGivenASolutionWithGlobalSectionNotClosedItThrows()
             };
 
             action.ShouldThrow<InvalidSolutionFormatException>()
-                .WithMessage("Invalid format in line 3: Global section not closed");
+                .WithMessage(FormatError(3, LocalizableStrings.GlobalSectionNotClosedError));
         }
 
         [Fact]
@@ -381,7 +381,7 @@ public void WhenGivenASolutionWithProjectSectionNotClosedItThrows()
             };
 
             action.ShouldThrow<InvalidSolutionFormatException>()
-                .WithMessage("Invalid format in line 3: Project section not closed");
+                .WithMessage(FormatError(3, LocalizableStrings.ProjectSectionNotClosedError));
         }
 
         [Fact]
@@ -402,7 +402,7 @@ public void WhenGivenASolutionWithInvalidProjectSectionItThrows()
             };
 
             action.ShouldThrow<InvalidSolutionFormatException>()
-                .WithMessage("Invalid format in line 3: Project section is missing '(' when parsing the line starting at position 0");
+                .WithMessage(FormatError(3, LocalizableStrings.ProjectParsingErrorFormatString, "(", 0));
         }
 
         [Fact]
@@ -424,7 +424,7 @@ public void WhenGivenASolutionWithInvalidSectionTypeItThrows()
             };
 
             action.ShouldThrow<InvalidSolutionFormatException>()
-                .WithMessage("Invalid format in line 4: Invalid section type: thisIsUnknown");
+                .WithMessage(FormatError(4, LocalizableStrings.InvalidSectionTypeError, "thisIsUnknown"));
         }
 
         [Fact]
@@ -446,7 +446,7 @@ public void WhenGivenASolutionWithMissingSectionIdTypeItThrows()
             };
 
             action.ShouldThrow<InvalidSolutionFormatException>()
-                .WithMessage("Invalid format in line 4: Section id missing");
+                .WithMessage(FormatError(4, LocalizableStrings.SectionIdMissingError));
         }
 
         [Fact]
@@ -467,7 +467,7 @@ public void WhenGivenASolutionWithSectionNotClosedItThrows()
             };
 
             action.ShouldThrow<InvalidSolutionFormatException>()
-                .WithMessage("Invalid format in line 6: Closing section tag not found");
+                .WithMessage(FormatError(6, LocalizableStrings.ClosingSectionTagNotFoundError));
         }
 
         [Fact]
@@ -496,7 +496,15 @@ public void WhenGivenASolutionWithInvalidPropertySetItThrows()
             };
 
             action.ShouldThrow<InvalidSolutionFormatException>()
-                .WithMessage("Invalid format in line 7: Property set is missing '.'");
+                .WithMessage(FormatError(7, LocalizableStrings.InvalidPropertySetFormatString, "."));
+        }
+
+        private static string FormatError(int line, string format, params object[] args)
+        {
+            return string.Format(
+                LocalizableStrings.ErrorMessageFormatString,
+                line,
+                string.Format(format, args));
         }
     }
 }