Skip to content
This repository was archived by the owner on Apr 20, 2023. It is now read-only.

Commit 7a606a4

Browse files
author
Nate McMaster
committed
Update SPA tests to skip npm-restore
1 parent 223bc83 commit 7a606a4

File tree

2 files changed

+12
-9
lines changed

2 files changed

+12
-9
lines changed

build/BundledRuntimes.props

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -28,18 +28,19 @@
2828
<SharedFrameworkRid Condition=" '$(UsePortableLinuxSharedFramework)' == 'true' ">linux-x64</SharedFrameworkRid>
2929
<CombinedFrameworkHostCompressedFileName>dotnet-runtime-$(MicrosoftNETCoreAppPackageVersion)-$(SharedFrameworkRid)$(ArchiveExtension)</CombinedFrameworkHostCompressedFileName>
3030

31-
<AspNetCoreSharedFrameworkRid>$(SharedFrameworkRid)</AspNetCoreSharedFrameworkRid>
32-
<AspNetCoreSharedFrameworkRid Condition="'$(SharedFrameworkRid)' == 'alpine.3.6-x64'">linux-x64</AspNetCoreSharedFrameworkRid>
33-
<AspNetCoreSharedFrameworkRid Condition="'$(SharedFrameworkRid)' == 'rhel.6-x64'">linux-x64</AspNetCoreSharedFrameworkRid>
34-
<AspNetCoreSharedFrameworkRid Condition="'$(InstallerExtension)' == '.deb'">$(CoreSetupRid)</AspNetCoreSharedFrameworkRid>
35-
<AspNetCoreSharedFrameworkRid Condition="'$(InstallerExtension)' == '.rpm'">$(CoreSetupRid)</AspNetCoreSharedFrameworkRid>
36-
37-
<DownloadedAspNetCoreSharedFxInstallerFileName Condition=" '$(InstallerExtension)' != '' AND '$(HostOSName)' != 'osx' ">aspnetcore-runtime-$(AspNetCoreVersion)-$(AspNetCoreSharedFrameworkRid)$(InstallerExtension)</DownloadedAspNetCoreSharedFxInstallerFileName>
31+
<AspNetCoreSharedFxInstallerRid>$(SharedFrameworkRid)</AspNetCoreSharedFxInstallerRid>
32+
<AspNetCoreSharedFxInstallerRid Condition="'$(SharedFrameworkRid)' == 'alpine.3.6-x64'">linux-x64</AspNetCoreSharedFxInstallerRid>
33+
<AspNetCoreSharedFxInstallerRid Condition="'$(SharedFrameworkRid)' == 'rhel.6-x64'">linux-x64</AspNetCoreSharedFxInstallerRid>
34+
<AspNetCoreSharedFxArchiveRid>$(AspNetCoreSharedFxInstallerRid)</AspNetCoreSharedFxArchiveRid>
35+
<AspNetCoreSharedFxInstallerRid Condition="'$(InstallerExtension)' == '.deb'">$(CoreSetupRid)</AspNetCoreSharedFxInstallerRid>
36+
<AspNetCoreSharedFxInstallerRid Condition="'$(InstallerExtension)' == '.rpm'">$(CoreSetupRid)</AspNetCoreSharedFxInstallerRid>
37+
38+
<DownloadedAspNetCoreSharedFxInstallerFileName Condition=" '$(InstallerExtension)' != '' AND '$(HostOSName)' != 'osx' ">aspnetcore-runtime-$(AspNetCoreVersion)-$(AspNetCoreSharedFxInstallerRid)$(InstallerExtension)</DownloadedAspNetCoreSharedFxInstallerFileName>
3839
<!-- Note: we use the "-internal" archives and installers that contain only the aspnetcore shared framework, and shouldn't overlap with Microsoft.NETCore.App. -->
39-
<DownloadedAspNetCoreSharedFxInstallerFileName Condition=" '$(InstallerExtension)' == '.msi' ">aspnetcore-runtime-internal-$(AspNetCoreVersion)-$(AspNetCoreSharedFrameworkRid).wixlib</DownloadedAspNetCoreSharedFxInstallerFileName>
40+
<DownloadedAspNetCoreSharedFxInstallerFileName Condition=" '$(InstallerExtension)' == '.msi' ">aspnetcore-runtime-internal-$(AspNetCoreVersion)-$(AspNetCoreSharedFxInstallerRid).wixlib</DownloadedAspNetCoreSharedFxInstallerFileName>
4041
<DownloadedAspNetCoreSharedFxInstallerFile Condition=" '$(InstallerExtension)' != '' AND '$(DownloadedAspNetCoreSharedFxInstallerFileName)' != '' ">$(PackagesDirectory)/$(DownloadedAspNetCoreSharedFxInstallerFileName)</DownloadedAspNetCoreSharedFxInstallerFile>
4142

42-
<AspNetCoreSharedFxArchiveFileName>aspnetcore-runtime-internal-$(AspNetCoreVersion)-$(SharedFrameworkRid)$(ArchiveExtension)</AspNetCoreSharedFxArchiveFileName>
43+
<AspNetCoreSharedFxArchiveFileName>aspnetcore-runtime-internal-$(AspNetCoreVersion)-$(AspNetCoreSharedFxArchiveRid)$(ArchiveExtension)</AspNetCoreSharedFxArchiveFileName>
4344
<AspNetCoreSharedFxArchiveFile>$(PackagesDirectory)/$(AspNetCoreSharedFxArchiveFileName)</AspNetCoreSharedFxArchiveFile>
4445

4546
<!-- Used to detect if ASP.NET Core is built against the same version of Microsoft.NETCore.App. -->

test/dotnet-new.Tests/GivenThatIWantANewAppWithSpecifiedType.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,8 @@ public void TemplateRestoresAndBuildsWithoutWarnings(
5959
// Not all CI machines have Node installed, so the build would fail if we tried
6060
// to run Webpack. Bypass this by making it appear that Webpack already ran.
6161
Directory.CreateDirectory(Path.Combine(rootPath, "wwwroot", "dist"));
62+
Directory.CreateDirectory(Path.Combine(rootPath, "ClientApp", "node_modules"));
63+
Directory.CreateDirectory(Path.Combine(rootPath, "node_modules"));
6264
}
6365

6466
new TestCommand("dotnet")

0 commit comments

Comments
 (0)