Skip to content
This repository was archived by the owner on Apr 20, 2023. It is now read-only.

Commit 7e0747e

Browse files
Bundle SPA templates package
1 parent ac3ed6f commit 7e0747e

File tree

3 files changed

+26
-13
lines changed

3 files changed

+26
-13
lines changed

build/BundledTemplates.props

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,5 +5,6 @@
55
<BundledTemplate Include="Microsoft.DotNet.Common.ProjectTemplates.2.0" Version="$(TemplateEngineTemplate2_0Version)" />
66
<BundledTemplate Include="Microsoft.DotNet.Test.ProjectTemplates.2.0" Version="$(TemplateEngineTemplateVersion)" />
77
<BundledTemplate Include="Microsoft.DotNet.Web.ProjectTemplates.2.0" Version="$(TemplateEngineTemplateVersion)" />
8+
<BundledTemplate Include="Microsoft.DotNet.Web.Spa.ProjectTemplates" Version="$(SpaTemplateVersion)" />
89
</ItemGroup>
910
</Project>

build/DependencyVersions.props

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
<CliCommandLineParserVersion>0.1.0-alpha-142</CliCommandLineParserVersion>
2222
<CliMigrateVersion>1.2.1-alpha-002130</CliMigrateVersion>
2323
<MicroBuildVersion>0.2.0</MicroBuildVersion>
24+
<SpaTemplateVersion>1.0.0-preview-000249</SpaTemplateVersion>
2425

2526
<!-- This should either be timestamped or notimestamp as appropriate -->
2627
<AspNetCoreRuntimePackageFlavor>timestamped</AspNetCoreRuntimePackageFlavor>

test/dotnet-new.Tests/GivenThatIWantANewAppWithSpecifiedType.cs

Lines changed: 24 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -16,22 +16,26 @@ namespace Microsoft.DotNet.New.Tests
1616
public class GivenThatIWantANewAppWithSpecifiedType : TestBase
1717
{
1818
[Theory]
19-
[InlineData("C#", "console", false)]
20-
[InlineData("C#", "classlib", false)]
21-
[InlineData("C#", "mstest", false)]
22-
[InlineData("C#", "xunit", false)]
23-
[InlineData("C#", "web", false)]
24-
[InlineData("C#", "mvc", false)]
25-
[InlineData("C#", "webapi", false)]
26-
[InlineData("F#", "console", false)]
27-
[InlineData("F#", "classlib", false)]
28-
[InlineData("F#", "mstest", false)]
29-
[InlineData("F#", "xunit", false)]
30-
[InlineData("F#", "mvc", true)]
19+
[InlineData("C#", "console", false, false)]
20+
[InlineData("C#", "classlib", false, false)]
21+
[InlineData("C#", "mstest", false, false)]
22+
[InlineData("C#", "xunit", false, false)]
23+
[InlineData("C#", "web", false, false)]
24+
[InlineData("C#", "mvc", false, false)]
25+
[InlineData("C#", "webapi", false, false)]
26+
[InlineData("C#", "angular", false, true)]
27+
[InlineData("C#", "react", false, true)]
28+
[InlineData("C#", "reactredux", false, true)]
29+
[InlineData("F#", "console", false, false)]
30+
[InlineData("F#", "classlib", false, false)]
31+
[InlineData("F#", "mstest", false, false)]
32+
[InlineData("F#", "xunit", false, false)]
33+
[InlineData("F#", "mvc", true, false)]
3134
public void TemplateRestoresAndBuildsWithoutWarnings(
3235
string language,
3336
string projectType,
34-
bool useNuGetConfigForAspNet)
37+
bool useNuGetConfigForAspNet,
38+
bool skipSpaWebpackSteps)
3539
{
3640
if (language == "F#" && !EnvironmentInfo.HasSharedFramework("netcoreapp1.0"))
3741
{
@@ -52,6 +56,13 @@ public void TemplateRestoresAndBuildsWithoutWarnings(
5256
File.Copy(configFile.FullName, Path.Combine(rootPath, "NuGet.Config"));
5357
}
5458

59+
if (skipSpaWebpackSteps)
60+
{
61+
// Not all CI machines have Node installed, so the build would fail if we tried
62+
// to run Webpack. Bypass this by making it appear that Webpack already ran.
63+
Directory.CreateDirectory(Path.Combine(rootPath, "wwwroot", "dist"));
64+
}
65+
5566
new TestCommand("dotnet")
5667
.WithWorkingDirectory(rootPath)
5768
.Execute($"restore")

0 commit comments

Comments
 (0)