Revert "Disabling the VB tests in non-windows platforms while MSBuild fixes a bug that we need for cross-plat."

rainersigwald · rainersigwald · commit a3dbfa47c9ed · 2017-05-22T13:06:34.000-05:00
This reverts commit a4c3e69. This should work since 28e2565 picked up the fix for dotnet/msbuild#137.
diff --git a/test/dotnet.Tests/GivenThatICareAboutVBApps.cs b/test/dotnet.Tests/GivenThatICareAboutVBApps.cs
@@ -26,8 +26,7 @@ public GivenThatICareAboutVBApps()
                 .Should().Pass();
         }
 
-        // Enable cross-plat once https://github.com/Microsoft/msbuild/issues/422 is fixed
-        [WindowsOnlyFact]
+        [Fact]
         public void ICanBuildVBApps()
         {
             new BuildCommand()
@@ -36,8 +35,7 @@ public void ICanBuildVBApps()
                 .Should().Pass();
         }
 
-        // Enable cross-plat once https://github.com/Microsoft/msbuild/issues/422 is fixed
-        [WindowsOnlyFact]
+        [Fact]
         public void ICanRunVBApps()
         {
             new RunCommand()
@@ -46,8 +44,7 @@ public void ICanRunVBApps()
                 .Should().Pass();
         }
 
-        // Enable cross-plat once https://github.com/Microsoft/msbuild/issues/422 is fixed
-        [WindowsOnlyFact]
+        [Fact]
         public void ICanPublicAndRunVBApps()
         {
             new PublishCommand()

Original file line number	Diff line number	Diff line change
`@@ -26,8 +26,7 @@ public GivenThatICareAboutVBApps()`
`26`	`26`	`.Should().Pass();`
`27`	`27`	`}`
`28`	`28`
`29`		`- // Enable cross-plat once https://github.com/Microsoft/msbuild/issues/422 is fixed`
`30`		`- [WindowsOnlyFact]`
	`29`	`+ [Fact]`
`31`	`30`	`public void ICanBuildVBApps()`
`32`	`31`	`{`
`33`	`32`	`new BuildCommand()`
`@@ -36,8 +35,7 @@ public void ICanBuildVBApps()`
`36`	`35`	`.Should().Pass();`
`37`	`36`	`}`
`38`	`37`
`39`		`- // Enable cross-plat once https://github.com/Microsoft/msbuild/issues/422 is fixed`
`40`		`- [WindowsOnlyFact]`
	`38`	`+ [Fact]`
`41`	`39`	`public void ICanRunVBApps()`
`42`	`40`	`{`
`43`	`41`	`new RunCommand()`
`@@ -46,8 +44,7 @@ public void ICanRunVBApps()`
`46`	`44`	`.Should().Pass();`
`47`	`45`	`}`
`48`	`46`
`49`		`- // Enable cross-plat once https://github.com/Microsoft/msbuild/issues/422 is fixed`
`50`		`- [WindowsOnlyFact]`
	`47`	`+ [Fact]`
`51`	`48`	`public void ICanPublicAndRunVBApps()`
`52`	`49`	`{`
`53`	`50`	`new PublishCommand()`