Skip to content
This repository was archived by the owner on Apr 20, 2023. It is now read-only.

Commit b44bce5

Browse files
committed
Fix dotnet store options
- remove configuration - remove preserve-working-dir - add skip-symbols Fix #6488 Fix #6489 Fix #6490
1 parent 6647edd commit b44bce5

File tree

2 files changed

+7
-8
lines changed

2 files changed

+7
-8
lines changed

src/dotnet/commands/dotnet-store/LocalizableStrings.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,12 +21,12 @@ internal class LocalizableStrings
2121

2222
public const string SkipOptimizationOptionDescription = "Skips the optimization phase.";
2323

24+
public const string SkipSymbolsOptionDescription = "Skips creating symbol files which can be used for profiling the optimized assemblies.";
25+
2426
public const string IntermediateWorkingDirOption = "IntermediateWorkingDir";
2527

2628
public const string IntermediateWorkingDirOptionDescription = "The directory used by the command to execute.";
2729

28-
public const string PreserveIntermediateWorkingDirOptionDescription = "Preserves the intermediate working directory.";
29-
3030
public const string SpecifyManifests = "Specify at least one manifest with --manifest.";
3131

3232
public const string IntermediateDirExists = "Intermediate working directory {0} already exists. Remove {0} or specify another directory with -w.";

src/dotnet/commands/dotnet-store/StoreCommandParser.cs

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,6 @@ public static Command Store() =>
4949
.With(name: LocalizableStrings.FrameworkVersionOption)
5050
.ForwardAsSingle(o => $"/p:RuntimeFrameworkVersion={o.Arguments.Single()}")),
5151
CommonOptions.RuntimeOption(),
52-
CommonOptions.ConfigurationOption(),
5352
Create.Option(
5453
"-o|--output",
5554
LocalizableStrings.OutputOptionDescription,
@@ -62,16 +61,16 @@ public static Command Store() =>
6261
Accept.ExactlyOneArgument()
6362
.With(name: LocalizableStrings.IntermediateWorkingDirOption)
6463
.ForwardAsSingle(o => $"/p:ComposeWorkingDir={o.Arguments.Single()}")),
65-
Create.Option(
66-
"--preserve-working-dir",
67-
LocalizableStrings.PreserveIntermediateWorkingDirOptionDescription,
68-
Accept.NoArguments()
69-
.ForwardAsSingle(o => $"/p:PreserveComposeWorkingDir=true")),
7064
Create.Option(
7165
"--skip-optimization",
7266
LocalizableStrings.SkipOptimizationOptionDescription,
7367
Accept.NoArguments()
7468
.ForwardAs("/p:SkipOptimization=true")),
69+
Create.Option(
70+
"--skip-symbols",
71+
LocalizableStrings.SkipSymbolsOptionDescription,
72+
Accept.NoArguments()
73+
.ForwardAs("/p:CreateProfilingSymbols=false")),
7574
CommonOptions.VerbosityOption());
7675
}
7776
}

0 commit comments

Comments
 (0)