Skip to content
This repository was archived by the owner on Apr 20, 2023. It is now read-only.

Commit bc24634

Browse files
committed
Add comment clarifying why net* folders from Microsoft.NET.Build.Extensions package are excluded
1 parent 3a61ba1 commit bc24634

File tree

1 file changed

+10
-0
lines changed

1 file changed

+10
-0
lines changed

build/MSBuildExtensions.targets

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,20 @@
55
<ItemGroup>
66
<MSBuildExtensionsContent Include="$(GeneratedMSBuildExtensionsDirectory)/**/*" />
77

8+
<!-- We want to include the tasks and targets from the Microsoft.NET.Build.Extensions package, but we don't want to include the DLLs
9+
from that package under the net461, net462, etc folders. That is because they come from the NETStandard.Library.NETFramework
10+
package, and we want to insert them directly into the CLI from CoreFx instead of having to do a two-hop insertion (CoreFX -> SDK -> CLI)
11+
if we need to update them.
12+
13+
https://github.com/dotnet/sdk/issues/1324 has been filed to exclude these from the Microsoft.NET.Build.Extensions package when
14+
we generate it.
15+
-->
816
<MSBuildExtensionsContent Include="$(MSBuildExtensionsNuPkgPath)\msbuildExtensions\**\*.*"
917
Exclude="$(MSBuildExtensionsNuPkgPath)\msbuildExtensions\Microsoft.NET.Build.Extensions\net*\**" />
18+
1019
<MSBuildExtensionsContent Include="$(MSBuildExtensionsNuPkgPath)\msbuildExtensions-ver\**\*.*"
1120
DeploymentSubpath="$(MSBuildExtensionsVersionSubfolder)/" />
21+
1222
<MSBuildExtensionsContent Include="$(NETStandardLibraryNETFrameworkNuPkgPath)\build\**\*.*"
1323
Exclude="$(NETStandardLibraryNETFrameworkNuPkgPath)\build\**\*.props;$(NETStandardLibraryNETFrameworkNuPkgPath)\build\**\*.targets"
1424
DeploymentSubpath="Microsoft.NET.Build.Extensions/" />

0 commit comments

Comments
 (0)