Ensure tool package store root is a full path.

This commit fixes the tool package store such that it stores a full path
instead of, potentially, a relative path.

This prevents a relative path from inadvertently being passed to NuGet
during the restore and causing it to restore relative to the temp project
directory.

Fixes #8829.

Author: Peter Huene

src/dotnet/ToolPackage/ToolPackageStore.cs

@@ -14,7 +14,7 @@ internal class ToolPackageStore : IToolPackageStore
 
         public ToolPackageStore(DirectoryPath root)
         {
-            Root = root;
+            Root = new DirectoryPath(Path.GetFullPath(root.Value));
         }
 
         public DirectoryPath Root { get; private set; }

test/Microsoft.DotNet.ToolPackage.Tests/ToolPackageInstallerTests.cs

@@ -637,7 +637,7 @@ private static (IToolPackageStore, IToolPackageInstaller, BufferedReporter, IFil
             FilePath? tempProject = null,
             DirectoryPath? offlineFeed = null)
         {
-            var root = new DirectoryPath(Path.Combine(Path.GetFullPath(TempRoot.Root), Path.GetRandomFileName()));
+            var root = new DirectoryPath(Path.Combine(TempRoot.Root, Path.GetRandomFileName()));
             var reporter = new BufferedReporter();
 
             IFileSystem fileSystem;
@@ -666,6 +666,8 @@ private static (IToolPackageStore, IToolPackageInstaller, BufferedReporter, IFil
                     offlineFeed: offlineFeed ?? new DirectoryPath("does not exist"));
             }
 
+            store.Root.Value.Should().Be(Path.GetFullPath(root.Value));
+
             return (store, installer, reporter, fileSystem);
         }
 

test/Microsoft.DotNet.Tools.Tests.ComponentMocks/ToolPackageStoreMock.cs

@@ -22,7 +22,7 @@ public ToolPackageStoreMock(
             IFileSystem fileSystem,
             Action uninstallCallback = null)
         {
-            Root = root;
+            Root = new DirectoryPath(Path.GetFullPath(root.Value));
             _fileSystem = fileSystem ?? throw new ArgumentNullException(nameof(fileSystem));
             _uninstallCallback = uninstallCallback;
         }

test/dotnet.Tests/CommandTests/UninstallToolCommandTests.cs

@@ -73,7 +73,8 @@ public void GivenAPackageItUninstalls()
                     PackageId,
                     PackageVersion));
 
-            var packageDirectory = new DirectoryPath(ToolsDirectory).WithSubDirectories(PackageId, PackageVersion);
+            var packageDirectory = new DirectoryPath(Path.GetFullPath(ToolsDirectory))
+                .WithSubDirectories(PackageId, PackageVersion);
             var shimPath = Path.Combine(
                 ShimsDirectory,
                 ProjectRestorerMock.FakeCommandName +
@@ -114,7 +115,8 @@ public void GivenAFailureToUninstallItLeavesItInstalled()
                     PackageId,
                     PackageVersion));
 
-            var packageDirectory = new DirectoryPath(ToolsDirectory).WithSubDirectories(PackageId, PackageVersion);
+            var packageDirectory = new DirectoryPath(Path.GetFullPath(ToolsDirectory))
+                .WithSubDirectories(PackageId, PackageVersion);
             var shimPath = Path.Combine(
                 ShimsDirectory,
                 ProjectRestorerMock.FakeCommandName +