Skip to content
This repository was archived by the owner on Apr 20, 2023. It is now read-only.

Commit d613ec5

Browse files
committed
Making the cli-test-env shell script runnable and removing test workaround for preview runtimes. It is not needed in master.
1 parent d48654a commit d613ec5

File tree

6 files changed

+3
-41
lines changed

6 files changed

+3
-41
lines changed

build/BundledRuntimes.props

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,6 @@
2121
<SharedFrameworkRid>$(CoreSetupRid)</SharedFrameworkRid>
2222
<SharedFrameworkRid Condition=" '$(UsePortableLinuxSharedFramework)' == 'true' ">linux-x64</SharedFrameworkRid>
2323
<CombinedFrameworkHostCompressedFileName>dotnet-runtime-$(SharedFrameworkVersion)-$(SharedFrameworkRid)$(ArchiveExtension)</CombinedFrameworkHostCompressedFileName>
24-
25-
<IsSharedFrameworkPreReleaseVersion>$([System.Text.RegularExpressions.Regex]::IsMatch($(SharedFrameworkVersion), '\d*\.\d*\.\d*-'))</IsSharedFrameworkPreReleaseVersion>
26-
<SharedFrameworkStableVersion>$([System.Text.RegularExpressions.Regex]::Match($(SharedFrameworkVersion), '\d*\.\d*\.\d*').get_Groups().get_Item(0).ToString())</SharedFrameworkStableVersion>
2724
</PropertyGroup>
2825

2926
<PropertyGroup>

build/Test.targets

Lines changed: 0 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -35,35 +35,6 @@
3535
</ProjectsToTest>
3636
</ItemGroup>
3737

38-
<!-- Begin Workaround lack of a stable package version for depedencies; copy into simulated stable version folders -->
39-
40-
<PropertyGroup>
41-
<StableSharedFrameworkDirectory>$(OutputDirectory)/shared/Microsoft.NETCore.App/$(SharedFrameworkStableVersion)</StableSharedFrameworkDirectory>
42-
<StableSharedFrameworkDirectoryWithBackwardsCompatibleRuntimes>$(Stage2WithBackwardsCompatibleRuntimesOutputDirectory)/shared/Microsoft.NETCore.App/$(SharedFrameworkStableVersion)</StableSharedFrameworkDirectoryWithBackwardsCompatibleRuntimes>
43-
</PropertyGroup>
44-
45-
<ItemGroup>
46-
<Stabilize_SourceFiles_2_0 Include="$(OutputDirectory)/shared/Microsoft.NETCore.App/$(CLI_SharedFrameworkVersion)/*.*"/>
47-
<SimulatedStableSharedFrameworkDirectories Condition=" '$(IsSharedFrameworkPreReleaseVersion)' == 'True' "
48-
Include="$(StableSharedFrameworkDirectory)" />
49-
<SimulatedStableSharedFrameworkDirectories Condition=" '$(IsSharedFrameworkPreReleaseVersion)' == 'True' "
50-
Include="$(StableSharedFrameworkDirectoryWithBackwardsCompatibleRuntimes)" />
51-
</ItemGroup>
52-
53-
<Copy
54-
Condition=" '$(IsSharedFrameworkPreReleaseVersion)' == 'True' "
55-
SourceFiles="@(Stabilize_SourceFiles_2_0)"
56-
DestinationFiles="@(Stabilize_SourceFiles_2_0->'$(StableSharedFrameworkDirectory)/%(RecursiveDir)%(Filename)%(Extension)')"
57-
/>
58-
59-
<Copy
60-
Condition=" '$(IsSharedFrameworkPreReleaseVersion)' == 'True' "
61-
SourceFiles="@(Stabilize_SourceFiles_2_0)"
62-
DestinationFiles="@(Stabilize_SourceFiles_2_0->'$(StableSharedFrameworkDirectoryWithBackwardsCompatibleRuntimes)/%(RecursiveDir)%(Filename)%(Extension)')"
63-
/>
64-
65-
<!-- End Workaround lack of a stable package version for depedencies; copy into simulated stable versions -->
66-
6738
<Message Text="Starting test execution" Importance="High" />
6839

6940
<MSBuild
@@ -72,12 +43,6 @@
7243
</MSBuild>
7344

7445
<Message Text="Finished test execution" Importance="High" />
75-
76-
<!-- Begin Workaround lack of a stable package version for depedencies; remove simulated stable version folder. -->
77-
78-
<RemoveDir Directories="@(SimulatedStableSharedFrameworkDirectories)" />
79-
80-
<!-- End Workaround lack of a stable package version for depedencies; remove simulated stable version folder. -->
8146
</Target>
8247

8348
<Target Name="PrepareTests"

build/package/Installer.DEB.proj

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@
9797
</Target>
9898

9999
<Target Name="TestSdkDeb"
100-
Condition=" '$(IsDebianBaseDistro)' == 'True' and '$(DebuildPresent)' == 'true' and '$(IsSharedFrameworkPreReleaseVersion)' != 'True' "
100+
Condition=" '$(IsDebianBaseDistro)' == 'True' and '$(DebuildPresent)' == 'true' "
101101
DependsOnTargets="RestoreTests"
102102
Inputs="$(DownloadedSharedHostInstallerFile);
103103
$(DownloadedHostFxrInstallerFile);

build/package/Installer.RPM.targets

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -228,7 +228,7 @@
228228

229229
<Target Name="TestSdkRpm"
230230
DependsOnTargets="RestoreTests;DownloadAspNetCoreRuntimeRpmInstaller"
231-
Condition=" '$(IsRPMBasedDistro)' == 'True' and '$(FPMPresent)' == 'True' and '$(IsSharedFrameworkPreReleaseVersion)' != 'True' "
231+
Condition=" '$(IsRPMBasedDistro)' == 'True' and '$(FPMPresent)' == 'True' "
232232
Inputs="$(DownloadedSharedHostInstallerFile);
233233
$(DownloadedHostFxrInstallerFile);
234234
$(DownloadedSharedFrameworkInstallerFile);

scripts/cli-test-env.sh

100644100755
File mode changed.

test/Microsoft.DotNet.Cli.Utils.Tests/GivenAProjectToolsCommandResolver.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -303,7 +303,7 @@ public void ItAddsFxVersionAsAParamWhenTheToolHasThePrefercliruntimeFile()
303303
var result = projectToolsCommandResolver.Resolve(commandResolverArguments);
304304

305305
result.Should().NotBeNull();
306-
306+
307307
result.Args.Should().Contain("--fx-version 2.1.0");
308308
}
309309

0 commit comments

Comments
 (0)