-
Notifications
You must be signed in to change notification settings - Fork 4.9k
API Diff .NET 10.0 RC1 -> RC2 #10138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| - public static System.Numerics.Vector<T> get_E<T>() | ||
| - where T : System.Numerics.IFloatingPointConstants<T>; | ||
| - public static System.Numerics.Vector<T> get_Epsilon<T>() | ||
| - where T : System.Numerics.IFloatingPointIeee754<T>; | ||
| - public static System.Numerics.Vector<T> get_NaN<T>() | ||
| - where T : System.Numerics.IFloatingPointIeee754<T>; | ||
| - public static System.Numerics.Vector<T> get_NegativeInfinity<T>() | ||
| - where T : System.Numerics.IFloatingPointIeee754<T>; | ||
| - public static System.Numerics.Vector<T> get_NegativeOne<T>() | ||
| - where T : System.Numerics.ISignedNumber<T>; | ||
| - public static System.Numerics.Vector<T> get_NegativeZero<T>() | ||
| - where T : System.Numerics.IFloatingPointIeee754<T>; | ||
| - public static System.Numerics.Vector<T> get_Pi<T>() | ||
| - where T : System.Numerics.IFloatingPointConstants<T>; | ||
| - public static System.Numerics.Vector<T> get_PositiveInfinity<T>() | ||
| - where T : System.Numerics.IFloatingPointIeee754<T>; | ||
| - public static System.Numerics.Vector<T> get_Tau<T>() | ||
| - where T : System.Numerics.IFloatingPointConstants<T>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tannergooding I see these APIs ported to RC1 dotnet/dotnet#2016 but not to RC2?
https://github.com/dotnet/dotnet/blob/release/10.0.1xx-rc2-branding-update/src/runtime/src/libraries/System.Private.CoreLib/src/System/Numerics/Vector.cs
(I don't know if this is the right VMR rc2 branch)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We ship from VMR, so check the final code there and you'll see it's missing from GA as well. https://github.com/dotnet/dotnet/commits/release/10.0.1xx/src/runtime/src/libraries/System.Private.CoreLib/src/System/Numerics/Vector.cs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jozkee @tannergooding - have you filed a breaking change doc for this?
|
Ping |
bartonjs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
System.Security LGTM
ericstj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make sure to file breaking change for numerics/intrinsics removed API between RC1 and RC2. We can mention that these will ship in .NET 11 instead.
cc @ericstj