Remove EventPipeProfiler due to time constraints

Author: mjsabby

src/inc/corprof.idl

@@ -621,13 +621,11 @@ typedef enum
 
     COR_PRF_HIGH_IN_MEMORY_SYMBOLS_UPDATED          = 0x00000002,
 
-    COR_PRF_HIGH_MONITOR_EVENT_PIPE                 = 0x00000004,
-
-    COR_PRF_HIGH_MONITOR_DYNAMIC_FUNCTION_UNLOADS   = 0x00000008,
+    COR_PRF_HIGH_MONITOR_DYNAMIC_FUNCTION_UNLOADS   = 0x00000004,
 
     COR_PRF_HIGH_REQUIRE_PROFILE_IMAGE              = 0,
 
-    COR_PRF_HIGH_ALLOWABLE_AFTER_ATTACH             = COR_PRF_HIGH_IN_MEMORY_SYMBOLS_UPDATED | COR_PRF_HIGH_MONITOR_EVENT_PIPE | COR_PRF_HIGH_MONITOR_DYNAMIC_FUNCTION_UNLOADS,
+    COR_PRF_HIGH_ALLOWABLE_AFTER_ATTACH             = COR_PRF_HIGH_IN_MEMORY_SYMBOLS_UPDATED | COR_PRF_HIGH_MONITOR_DYNAMIC_FUNCTION_UNLOADS,
 
     // MONITOR_IMMUTABLE represents all flags that may only be set during initialization.
     // Trying to change any of these flags elsewhere will result in a
@@ -2424,17 +2422,6 @@ interface ICorProfilerCallback9 : ICorProfilerCallback8
     // and subsequently unloaded.
 
     HRESULT DynamicMethodUnloaded([in] FunctionID functionId);
-
-    HRESULT EventPipeEventDelivered(
-        [in] REFGUID eventGuid,
-        [in] DWORD eventId,
-        [in] DWORD eventVersion,
-        [in] DWORD eventThreadId,
-        [in] LARGE_INTEGER eventTimestamp,
-        [in] ULONG cbEventData,
-        [in, size_is(cbEventData)] LPCBYTE eventData,
-        [in] ULONG numStackFrames,
-        [in, length_is(numStackFrames)] UINT_PTR stackFrames[]);
 }
 
 

src/inc/profilepriv.inl

@@ -736,21 +736,6 @@ inline BOOL CORProfilerInMemorySymbolsUpdatesEnabled()
         ((&g_profControlBlock)->dwEventMaskHigh & COR_PRF_HIGH_IN_MEMORY_SYMBOLS_UPDATED));
 }
 
-inline BOOL CORProfilerIsMonitoringEventPipe()
-{
-    CONTRACTL
-    {
-        NOTHROW;
-        GC_NOTRIGGER;
-        CANNOT_TAKE_LOCK;
-        SO_NOT_MAINLINE;
-    }
-    CONTRACTL_END;
-
-    return (CORProfilerPresent() &&
-        ((&g_profControlBlock)->dwEventMaskHigh & COR_PRF_HIGH_MONITOR_EVENT_PIPE));
-}
-
 inline BOOL CORProfilerIsMonitoringDynamicFunctionUnloads()
 {
     CONTRACTL

src/vm/CMakeLists.txt

@@ -169,7 +169,6 @@ set(VM_SOURCES_WKS
     eventpipeeventinstance.cpp
     eventpipefile.cpp
     eventpipejsonfile.cpp
-    eventpipeprofilerapi.cpp
     eventpipeprovider.cpp
     eventstore.cpp
     fastserializer.cpp

src/vm/eetoprofinterfaceimpl.cpp

@@ -6390,36 +6390,5 @@ HRESULT EEToProfInterfaceImpl::GetAssemblyReferences(LPCWSTR wszAssemblyPath, IA
     return hr;
 }
 
-HRESULT EEToProfInterfaceImpl::EventPipeEventDelivered(
-    REFGUID eventGuid,
-    DWORD eventId,
-    DWORD eventVersion,
-    DWORD eventThreadId,
-    LARGE_INTEGER eventTimestamp,
-    ULONG cbEventData,
-    LPCBYTE eventData,
-    ULONG numStackFrames,
-    UINT_PTR stackFrames[])
-{
-    CONTRACTL
-    {
-        THROWS;
-        GC_TRIGGERS;
-        MODE_ANY;
-    }
-    CONTRACTL_END;
-
-    CLR_TO_PROFILER_ENTRYPOINT((LF_CORPROF,
-        LL_INFO1000,
-        "**PROF: EventPipeEventDelivered.\n"));
-
-    if (m_pCallback9 == NULL)
-    {
-        return S_OK;
-    }
-
-    return m_pCallback9->EventPipeEventDelivered(eventGuid, eventId, eventVersion, eventThreadId, eventTimestamp, cbEventData, eventData, numStackFrames, stackFrames);
-}
-
 
 #endif // PROFILING_SUPPORTED

src/vm/eetoprofinterfaceimpl.h

@@ -483,21 +483,6 @@ class EEToProfInterfaceImpl
 
     HRESULT GetAssemblyReferences(LPCWSTR wszAssemblyPath, IAssemblyBindingClosure * pClosure, AssemblyReferenceClosureWalkContextForProfAPI * pContext);
 
-    //
-    // Event Pipe
-    // 
-
-    HRESULT EventPipeEventDelivered(
-        REFGUID eventGuid,
-        DWORD eventId,
-        DWORD eventVersion,
-        DWORD eventThreadId,
-        LARGE_INTEGER eventTimestamp,
-        ULONG cbEventData,
-        LPCBYTE eventData,
-        ULONG numStackFrames,
-        UINT_PTR stackFrames[]);
-
 private:
 
     //

src/vm/eventpipe.cpp

@@ -9,11 +9,6 @@
 #include "eventpipefile.h"
 #include "eventpipeprovider.h"
 #include "eventpipejsonfile.h"
-
-#ifdef PROFILING_SUPPORTED
-#include "eventpipeprofilerapi.h"
-#endif
-
 #include "sampleprofiler.h"
 
 #ifdef FEATURE_PAL
@@ -28,10 +23,6 @@ EventPipeConfiguration* EventPipe::s_pConfig = NULL;
 EventPipeFile* EventPipe::s_pFile = NULL;
 EventPipeJsonFile* EventPipe::s_pJsonFile = NULL;
 
-#ifdef PROFILING_SUPPORTED
-EventPipeProfilerApi* EventPipe::s_pProfilerApi = NULL;
-#endif
-
 #ifdef FEATURE_PAL
 // This function is auto-generated from /src/scripts/genEventPipe.py
 extern "C" void InitProvidersAndEvents();
@@ -108,10 +99,6 @@ void EventPipe::Enable()
     eventPipeFileOutputPath.Printf("Process-%d.netperf", GetCurrentProcessId());
     s_pFile = new EventPipeFile(eventPipeFileOutputPath);
 
-#ifdef PROFILING_SUPPORTED
-    s_pProfilerApi = new EventPipeProfilerApi();
-#endif
-
     if(CLRConfig::GetConfigValue(CLRConfig::INTERNAL_PerformanceTracing) == 2)
     {
         // File placed in current working directory.
@@ -200,12 +187,6 @@ void EventPipe::WriteEvent(EventPipeEvent &event, BYTE *pData, unsigned int leng
     _ASSERTE(s_pFile != NULL);
     s_pFile->WriteEvent(instance);
 
-#ifdef PROFILING_SUPPORTED
-    // Write to the EventPipeProfilerApi.
-    _ASSERTE(s_pProfilerApi != NULL);
-    s_pProfilerApi->WriteEvent(instance);
-#endif
-
     // Write to the EventPipeJsonFile if it exists.
     if(s_pJsonFile != NULL)
     {
@@ -229,14 +210,6 @@ void EventPipe::WriteSampleProfileEvent(SampleProfilerEventInstance &instance)
         s_pFile->WriteEvent(instance);
     }
 
-#ifdef PROFILING_SUPPORTED
-    // Write to the EventPipeProfilerApi.
-    if(s_pProfilerApi != NULL)
-    {
-        s_pProfilerApi->WriteEvent(instance);
-    }
-#endif
-
     // Write to the EventPipeJsonFile if it exists.
     if(s_pJsonFile != NULL)
     {

src/vm/eventpipe.h

@@ -15,10 +15,6 @@ class EventPipeEvent;
 class EventPipeFile;
 class EventPipeJsonFile;
 
-#ifdef PROFILING_SUPPORTED
-class EventPipeProfilerApi;
-#endif
-
 class MethodDesc;
 class SampleProfilerEventInstance;
 

src/vm/eventpipeeventinstance.cpp

@@ -64,20 +64,6 @@ unsigned int EventPipeEventInstance::GetLength() const
     return m_dataLength;
 }
 
-unsigned int EventPipeEventInstance::GetThreadId() const
-{
-    LIMITED_METHOD_CONTRACT;
-
-    return m_threadID;
-}
-
-LARGE_INTEGER EventPipeEventInstance::GetTimestamp() const
-{
-    LIMITED_METHOD_CONTRACT;
-
-    return m_timeStamp;
-}
-
 void EventPipeEventInstance::FastSerialize(FastSerializer *pSerializer, StreamLabel metadataLabel)
 {
     CONTRACTL

src/vm/eventpipeeventinstance.h

@@ -31,12 +31,6 @@ class EventPipeEventInstance
     // Get the length of the data.
     unsigned int GetLength() const;
 
-    // Get the thread id of the event.
-    unsigned int GetThreadId() const;
-
-    // Get the timestamp of the event.
-    LARGE_INTEGER GetTimestamp() const;
-
     // Serialize this object using FastSerialization.
     void FastSerialize(FastSerializer *pSerializer, StreamLabel metadataLabel);