Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Commit 3512bb3

Browse files
author
Mike McLaughlin
committed
Restore missing native *.ni.pdb file from the Microsoft.NETCore.Runtime.CoreCLR (#12677)
Restore missing native *.ni.pdb file from the Microsoft.NETCore.Runtime.CoreCLR package DLLs that have native code, need both the *.pdb (for IL information) and the *.ni.pdb (for native information). When System.Private.Corlib was renamed from System.Private.Corlib.ni.pdb to System.Private.Corlib, the logic that decides what goes into the Microsoft.NETCore.Runtime.CoreCLR package lost the *.ni.pdb for System.Private.Corlib. This change basically causes this logic to search both for *.ni.pdb as well as the *.pdb file and thus fixes this issue.
1 parent 089fe7b commit 3512bb3

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

src/.nuget/dir.targets

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,8 @@
5151
<WindowsNativeFile Include="@(NativeWithSymbolFile)"
5252
Condition="'%(NativeWithSymbolFile.Extension)'=='.dll' OR '%(NativeWithSymbolFile.Extension)'=='.exe'" />
5353
<WindowsSymbolFile Include="@(WindowsNativeFile -> '%(RootDir)%(Directory)PDB\%(Filename).pdb')" />
54+
<!-- Crossgened files (on windows) have both a *.pdb and a *.ni.pdb symbol file. Include the *.ni.pdb file as well if it exists. -->
55+
<WindowsSymbolFile Include="@(WindowsNativeFile -> '%(RootDir)%(Directory)PDB\%(Filename).ni.pdb')" />
5456

5557
<!--
5658
Search for all xplat symbol file extensions on every xplat native binary. Some binaries have

0 commit comments

Comments
 (0)