Delete FriendAccessAllowedAttribute and associated dead code (#15101)

- Preserved commented out FriendAccessAllowed on types and methods that are still used as friends in System.Runtime.WindowsRuntime

Author: jkotas

src/inc/corhdr.h

@@ -1796,10 +1796,6 @@ typedef enum CorAttributeTargets
 #define FRIEND_ASSEMBLY_TYPE                     "System.Runtime.CompilerServices.InternalsVisibleToAttribute"
 #define FRIEND_ASSEMBLY_SIG                     {IMAGE_CEE_CS_CALLCONV_DEFAULT_HASTHIS, 2, ELEMENT_TYPE_VOID, ELEMENT_TYPE_STRING, ELEMENT_TYPE_BOOLEAN}
 
-#define FRIEND_ACCESS_ALLOWED_ATTRIBUTE_TYPE_W  L"System.Runtime.CompilerServices.FriendAccessAllowedAttribute"
-#define FRIEND_ACCESS_ALLOWED_ATTRIBUTE_TYPE     "System.Runtime.CompilerServices.FriendAccessAllowedAttribute"
-#define FRIEND_ACCESS_ALLOWED_SIG               {IMAGE_CEE_CS_CALLCONV_DEFAULT_HASTHIS, 0, ELEMENT_TYPE_VOID}
-
 #define SUBJECT_ASSEMBLY_TYPE_W                 L"System.Runtime.CompilerServices.IgnoresAccessChecksToAttribute"
 #define SUBJECT_ASSEMBLY_TYPE                    "System.Runtime.CompilerServices.IgnoresAccessChecksToAttribute"
 #define SUBJECT_ASSEMBLY_SIG                    {IMAGE_CEE_CS_CALLCONV_DEFAULT_HASTHIS, 1, ELEMENT_TYPE_VOID, ELEMENT_TYPE_STRING}

src/mscorlib/System.Private.CoreLib.csproj

@@ -119,7 +119,6 @@
   <!-- Sources -->
   <ItemGroup>
     <Compile Include="$(BclSourcesRoot)\System\Runtime\CompilerServices\RuntimeHelpers.cs" />
-    <Compile Include="$(BclSourcesRoot)\System\Runtime\CompilerServices\FriendAccessAllowedAttribute.cs" />
     <Compile Include="$(BclSourcesRoot)\System\Runtime\CompilerServices\TypeDependencyAttribute.cs" />
     <Compile Include="$(BclSourcesRoot)\System\Runtime\CompilerServices\jithelpers.cs" />
     <Compile Include="$(BclSourcesRoot)\System\Runtime\CompilerServices\Unsafe.cs" />
@@ -253,7 +252,6 @@
     <Compile Include="$(BclSourcesRoot)\System\Runtime\InteropServices\WindowsRuntime\ICustomPropertyProvider.cs" />
     <Compile Include="$(BclSourcesRoot)\System\Runtime\InteropServices\WindowsRuntime\ICustomProperty.cs" />
     <Compile Include="$(BclSourcesRoot)\System\Runtime\InteropServices\WindowsRuntime\CustomPropertyImpl.cs" />
-    <Compile Include="$(BclSourcesRoot)\System\Runtime\InteropServices\WindowsRuntime\WindowsRuntimeBufferHelper.cs" />
   </ItemGroup>
   <ItemGroup Condition="'$(FeatureCominterop)' == 'true'">
     <Compile Include="$(BclSourcesRoot)\System\Runtime\InteropServices\WindowsRuntime\IIterable.cs" />
@@ -334,7 +332,6 @@
     <Compile Include="$(BclSourcesRoot)\System\Attribute.cs" />
     <Compile Include="$(BclSourcesRoot)\System\BadImageFormatException.CoreCLR.cs" />
     <Compile Include="$(BclSourcesRoot)\System\Buffer.cs" />
-    <Compile Include="$(BclSourcesRoot)\System\CompatibilitySwitches.cs" />
     <Compile Include="$(BclSourcesRoot)\System\Currency.cs" />
     <Compile Include="$(BclSourcesRoot)\System\Decimal.cs" />
     <Compile Include="$(BclSourcesRoot)\System\DefaultBinder.CanConvert.cs" />

src/mscorlib/shared/System/Diagnostics/Tracing/Winmeta.cs

@@ -55,9 +55,6 @@ public enum EventLevel
     /// <summary>
     /// WindowsEventTask. Custom values must be in the range from 1 through 65534
     /// </summary>
-#if (!ES_BUILD_STANDALONE && !ES_BUILD_PN)
-    [System.Runtime.CompilerServices.FriendAccessAllowed]
-#endif
     public enum EventTask
     {
         /// <summary>
@@ -68,9 +65,6 @@ public enum EventTask
     /// <summary>
     /// EventOpcode. Custom values must be in the range from 11 through 239
     /// </summary>
-#if (!ES_BUILD_STANDALONE && !ES_BUILD_PN)
-    [System.Runtime.CompilerServices.FriendAccessAllowed]
-#endif
     public enum EventOpcode
     {
         /// <summary>
@@ -124,9 +118,6 @@ public enum EventOpcode
     /// EventChannel. Custom values must be in the range from 16 through 255. Currently only predefined values allowed.
     /// </summary>
     [System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.Design", "CA1028:EnumStorageShouldBeInt32", Justification = "Backwards compatibility")]
-#if (!ES_BUILD_STANDALONE && !ES_BUILD_PN)
-    [System.Runtime.CompilerServices.FriendAccessAllowed]
-#endif
     public enum EventChannel : byte
     {
         /// <summary>

src/mscorlib/shared/System/ObjectDisposedException.cs

@@ -72,7 +72,7 @@ public String ObjectName
         {
             get
             {
-                if ((_objectName == null)) // && !CompatibilitySwitches.IsAppEarlierThanWindowsPhone8)
+                if (_objectName == null)
                 {
                     return String.Empty;
                 }

src/mscorlib/src/System/AppDomain.cs

@@ -242,8 +242,6 @@ private void InitializeCompatibilityFlags()
             // case where the compat flags have been setup.
             Debug.Assert(!_compatFlagsInitialized);
             _compatFlagsInitialized = true;
-
-            CompatibilitySwitches.InitializeSwitches();
         }
 
         /// <summary>

src/mscorlib/src/System/Buffer.cs

@@ -243,7 +243,6 @@ internal unsafe static void Memcpy(byte* pDest, int destIndex, byte[] src, int s
         // This behavioral difference is unfortunate but intentional because
         // 1. This method is given access to other internal dlls and this close to release we do not want to change it.
         // 2. It is difficult to get this right for arm and again due to release dates we would like to visit it later.
-        [FriendAccessAllowed]
 #if ARM
         [MethodImplAttribute(MethodImplOptions.InternalCall)]
         internal unsafe static extern void Memcpy(byte* dest, byte* src, int len);

src/mscorlib/src/System/CompatibilitySwitches.cs

@@ -27,7 +27,7 @@ namespace System.Diagnostics.Tracing
     //
     // This will produce an XML file, where each event is pretty-printed with all its arguments nicely parsed.
     //
-    [FriendAccessAllowed]
+    // [FriendAccessAllowed]
     [EventSource(Guid = "8E9F5090-2D75-4d03-8A81-E5AFBF85DAF1", Name = "System.Diagnostics.Eventing.FrameworkEventSource")]
     sealed internal class FrameworkEventSource : EventSource
     {
@@ -52,7 +52,6 @@ public static class Keywords
         }
 
         /// <summary>ETW tasks that have start/stop events.</summary>
-        [FriendAccessAllowed]
         public static class Tasks // this name is important for EventSource
         {
             /// <summary>Begin / End - GetResponse.</summary>
@@ -63,7 +62,6 @@ public static class Keywords
             public const EventTask ThreadTransfer = (EventTask)3;
         }
 
-        [FriendAccessAllowed]
         public static class Opcodes
         {
             public const EventOpcode ReceiveHandled = (EventOpcode)11;

src/mscorlib/src/System/Diagnostics/Eventing/FrameworkEventSource.cs

@@ -183,7 +183,7 @@ public object RealErrorObject
             }
         }
 
-        [FriendAccessAllowed]
+        // [FriendAccessAllowed]
         internal void AddExceptionDataForRestrictedErrorInfo(
             string restrictedError,
             string restrictedErrorReference,
@@ -335,7 +335,7 @@ private string GetStackTrace(bool needFileInfo)
             return remoteStackTraceString + tempStackTraceString;
         }
 
-        [FriendAccessAllowed]
+        // [FriendAccessAllowed]
         internal void SetErrorCode(int hr)
         {
             HResult = hr;

src/mscorlib/src/System/Exception.cs

@@ -232,15 +232,6 @@ internal byte[] InternalGetBuffer()
             return _buffer;
         }
 
-        // PERF: Get origin and length - used in ResourceWriter.
-        [FriendAccessAllowed]
-        internal void InternalGetOriginAndLength(out int origin, out int length)
-        {
-            if (!_isOpen) __Error.StreamIsClosed();
-            origin = _origin;
-            length = _length;
-        }
-
         // PERF: True cursor position, we don't need _origin for direct access
         internal int InternalGetPosition()
         {