Allow COMPlus_JitHalt to display a pop-up on ARM/ARM64

BruceForstall · BruceForstall · commit 8c0e8e3929ef · 2018-01-18T13:28:25.000-08:00
Note that you need to `set COMPlus_NoGuiOnAssert=0` for the
pop-up to be displayed.
diff --git a/src/jit/compiler.cpp b/src/jit/compiler.cpp
@@ -5803,8 +5803,8 @@ void Compiler::compCompileFinish()
     {
         if (compJitHaltMethod())
         {
-#if !defined(_TARGET_ARMARCH_) && !defined(_HOST_UNIX_)
-            // TODO-ARM-NYI: re-enable this when we have an OS that supports a pop-up dialog
+#if !defined(_HOST_UNIX_)
+            // TODO-UNIX: re-enable this when we have an OS that supports a pop-up dialog
 
             // Don't do an assert, but just put up the dialog box so we get just-in-time debugger
             // launching.  When you hit 'retry' it will continue and naturally stop at the INT 3

Original file line number	Diff line number	Diff line change
`@@ -5803,8 +5803,8 @@ void Compiler::compCompileFinish()`
`5803`	`5803`	`{`
`5804`	`5804`	`if (compJitHaltMethod())`
`5805`	`5805`	`{`
`5806`		`-#if !defined(_TARGET_ARMARCH_) && !defined(_HOST_UNIX_)`
`5807`		`- // TODO-ARM-NYI: re-enable this when we have an OS that supports a pop-up dialog`
	`5806`	`+#if !defined(_HOST_UNIX_)`
	`5807`	`+ // TODO-UNIX: re-enable this when we have an OS that supports a pop-up dialog`
`5808`	`5808`
`5809`	`5809`	`// Don't do an assert, but just put up the dialog box so we get just-in-time debugger`
`5810`	`5810`	`// launching. When you hit 'retry' it will continue and naturally stop at the INT 3`