Removes unneeded Serializable attributes from enums and delegates. They can be serialized without attributes and this will remove noise from future serialization changes. (#11535)

morganbr · jkotas · commit 906f60ce3c55 · 2017-05-11T19:24:42.000-07:00
diff --git a/src/mscorlib/shared/System/AsyncCallback.cs b/src/mscorlib/shared/System/AsyncCallback.cs
@@ -12,6 +12,5 @@
 
 namespace System
 {
-    [Serializable]
     public delegate void AsyncCallback(IAsyncResult ar);
 }
diff --git a/src/mscorlib/shared/System/AttributeTargets.cs b/src/mscorlib/shared/System/AttributeTargets.cs
@@ -10,7 +10,6 @@ namespace System
     // Enum used to indicate all the elements of the
     // VOS it is valid to attach this element to.
     [Flags]
-    [Serializable]
     public enum AttributeTargets
     {
         Assembly = 0x0001,
diff --git a/src/mscorlib/shared/System/DateTimeKind.cs b/src/mscorlib/shared/System/DateTimeKind.cs
@@ -7,7 +7,6 @@ namespace System
     // This enum is used to indentify DateTime instances in cases when they are known to be in local time, 
     // UTC time or if this information has not been specified or is not applicable.
 
-    [Serializable]
     public enum DateTimeKind
     {
         Unspecified = 0,
diff --git a/src/mscorlib/shared/System/DayOfWeek.cs b/src/mscorlib/shared/System/DayOfWeek.cs
@@ -13,7 +13,6 @@
 
 namespace System
 {
-    [Serializable]
     public enum DayOfWeek
     {
         Sunday = 0,
diff --git a/src/mscorlib/shared/System/EventHandler.cs b/src/mscorlib/shared/System/EventHandler.cs
@@ -6,9 +6,7 @@
 
 namespace System
 {
-    [Serializable]
     public delegate void EventHandler(Object sender, EventArgs e);
 
-    [Serializable]
     public delegate void EventHandler<TEventArgs>(Object sender, TEventArgs e); // Removed TEventArgs constraint post-.NET 4
 }
diff --git a/src/mscorlib/shared/System/Globalization/CalendarWeekRule.cs b/src/mscorlib/shared/System/Globalization/CalendarWeekRule.cs
@@ -4,7 +4,6 @@
 
 namespace System.Globalization
 {
-    [Serializable]
     public enum CalendarWeekRule
     {
         FirstDay = 0,           // Week 1 begins on the first day of the year
diff --git a/src/mscorlib/shared/System/Globalization/GregorianCalendarTypes.cs b/src/mscorlib/shared/System/Globalization/GregorianCalendarTypes.cs
@@ -6,7 +6,6 @@ namespace System.Globalization
 {
     // Note: The values of the members of this enum must match the coresponding values
     // in the CalendarId enum (since we cast between GregorianCalendarTypes and CalendarId).
-    [Serializable]
     public enum GregorianCalendarTypes
     {
         Localized = CalendarId.GREGORIAN,
diff --git a/src/mscorlib/shared/System/IO/FileAccess.cs b/src/mscorlib/shared/System/IO/FileAccess.cs
@@ -9,7 +9,6 @@ namespace System.IO
     // Contains constants for specifying the access you want for a file.
     // You can have Read, Write or ReadWrite access.
     // 
-    [Serializable]
     [Flags]
     public enum FileAccess
     {
diff --git a/src/mscorlib/shared/System/Runtime/CompilerServices/CompilationRelaxations.cs b/src/mscorlib/shared/System/Runtime/CompilerServices/CompilationRelaxations.cs
@@ -6,7 +6,6 @@ namespace System.Runtime.CompilerServices
 {
     /// IMPORTANT: Keep this in sync with corhdr.h
     [Flags]
-    [Serializable]
     public enum CompilationRelaxations : int
     {
         NoStringInterning = 0x0008  // Start in 0x0008, we had other non public flags in this enum before,
diff --git a/src/mscorlib/shared/System/Runtime/CompilerServices/LoadHint.cs b/src/mscorlib/shared/System/Runtime/CompilerServices/LoadHint.cs
@@ -4,7 +4,6 @@
 
 namespace System.Runtime.CompilerServices
 {
-    [Serializable]
     public enum LoadHint
     {
         Default = 0x0000,           // No preference specified
diff --git a/src/mscorlib/shared/System/Runtime/CompilerServices/MethodCodeType.cs b/src/mscorlib/shared/System/Runtime/CompilerServices/MethodCodeType.cs
@@ -6,7 +6,6 @@
 
 namespace System.Runtime.CompilerServices
 {
-    [Serializable]
     public enum MethodCodeType
     {
         IL = MethodImplAttributes.IL,
diff --git a/src/mscorlib/shared/System/Runtime/ConstrainedExecution/Cer.cs b/src/mscorlib/shared/System/Runtime/ConstrainedExecution/Cer.cs
@@ -4,7 +4,6 @@
 
 namespace System.Runtime.ConstrainedExecution
 {
-    [Serializable]
     public enum Cer : int
     {
         None = 0,
diff --git a/src/mscorlib/shared/System/Runtime/ConstrainedExecution/Consistency.cs b/src/mscorlib/shared/System/Runtime/ConstrainedExecution/Consistency.cs
@@ -4,7 +4,6 @@
 
 namespace System.Runtime.ConstrainedExecution
 {
-    [Serializable]
     public enum Consistency : int
     {
         MayCorruptProcess = 0,
diff --git a/src/mscorlib/shared/System/StringComparison.cs b/src/mscorlib/shared/System/StringComparison.cs
@@ -4,7 +4,6 @@
 
 namespace System
 {
-    [Serializable]
     public enum StringComparison
     {
         CurrentCulture = 0,
diff --git a/src/mscorlib/shared/System/TypeCode.cs b/src/mscorlib/shared/System/TypeCode.cs
@@ -23,7 +23,6 @@
 
 namespace System
 {
-    [Serializable]
     public enum TypeCode
     {
         Empty = 0,          // Null reference
diff --git a/src/mscorlib/shared/System/UnhandledExceptionEventHandler.cs b/src/mscorlib/shared/System/UnhandledExceptionEventHandler.cs
@@ -4,6 +4,5 @@
 
 namespace System
 {
-    [Serializable]
     public delegate void UnhandledExceptionEventHandler(Object sender, UnhandledExceptionEventArgs e);
 }
diff --git a/src/mscorlib/src/System/AppDomain.cs b/src/mscorlib/src/System/AppDomain.cs
@@ -36,7 +36,6 @@ namespace System
     using System.Diagnostics.Contracts;
     using System.Runtime.ExceptionServices;
 
-    [Serializable]
     internal delegate void AppDomainInitializer(string[] args);
 
     internal class AppDomainInitializerInfo
diff --git a/src/mscorlib/src/System/AppDomainAttributes.cs b/src/mscorlib/src/System/AppDomainAttributes.cs
@@ -13,7 +13,6 @@
 
 namespace System
 {
-    [Serializable]
     internal enum LoaderOptimization
     {
         NotSpecified = 0,
diff --git a/src/mscorlib/src/System/AppDomainSetup.cs b/src/mscorlib/src/System/AppDomainSetup.cs
@@ -25,7 +25,6 @@ namespace System
     [Serializable]
     internal sealed class AppDomainSetup
     {
-        [Serializable]
         internal enum LoaderInformation
         {
             // If you add a new value, add the corresponding property
diff --git a/src/mscorlib/src/System/BCLDebug.cs b/src/mscorlib/src/System/BCLDebug.cs
@@ -22,7 +22,6 @@ namespace System
     using System.Security;
     using System.Diagnostics.Contracts;
 
-    [Serializable]
     internal enum LogLevel
     {
         Trace = 0,
diff --git a/src/mscorlib/src/System/Diagnostics/AssertFilters.cs b/src/mscorlib/src/System/Diagnostics/AssertFilters.cs
@@ -16,7 +16,6 @@
 
 namespace System.Diagnostics
 {
-    [Serializable]
     internal enum AssertFilters
     {
         FailDebug = 0,
diff --git a/src/mscorlib/src/System/Diagnostics/LoggingLevels.cs b/src/mscorlib/src/System/Diagnostics/LoggingLevels.cs
@@ -21,7 +21,6 @@ namespace System.Diagnostics
     // Constants representing the importance level of messages to be logged.
     // This level can be used to organize messages, and also to filter which
     // messages are displayed.
-    [Serializable]
     internal enum LoggingLevels
     {
         TraceLevel0 = 0,
diff --git a/src/mscorlib/src/System/Diagnostics/SymbolStore/SymAddressKind.cs b/src/mscorlib/src/System/Diagnostics/SymbolStore/SymAddressKind.cs
@@ -17,7 +17,6 @@
 
 namespace System.Diagnostics.SymbolStore
 {
-    [Serializable]
     internal enum SymAddressKind
     {
         // ILOffset: addr1 = IL local var or param index.
diff --git a/src/mscorlib/src/System/Diagnostics/log.cs b/src/mscorlib/src/System/Diagnostics/log.cs
@@ -19,7 +19,6 @@ namespace System.Diagnostics
     // NOTE: These are NOT triggered when the log switch setting is changed from the 
     // attached debugger.
     // 
-    [Serializable]
     internal delegate void LogSwitchLevelHandler(LogSwitch ls, LoggingLevels newLevel);
 
 
diff --git a/src/mscorlib/src/System/GC.cs b/src/mscorlib/src/System/GC.cs
@@ -28,7 +28,6 @@
 
 namespace System
 {
-    [Serializable]
     public enum GCCollectionMode
     {
         Default = 0,
@@ -39,7 +38,6 @@ public enum GCCollectionMode
     // !!!!!!!!!!!!!!!!!!!!!!!
     // make sure you change the def in vm\gc.h 
     // if you change this!
-    [Serializable]
     internal enum InternalGCCollectionMode
     {
         NonBlocking = 0x00000001,
@@ -51,7 +49,6 @@ internal enum InternalGCCollectionMode
     // !!!!!!!!!!!!!!!!!!!!!!!
     // make sure you change the def in vm\gc.h 
     // if you change this!
-    [Serializable]
     public enum GCNotificationStatus
     {
         Succeeded = 0,
diff --git a/src/mscorlib/src/System/Globalization/BidiCategory.cs b/src/mscorlib/src/System/Globalization/BidiCategory.cs
@@ -12,7 +12,6 @@
 
 namespace System.Globalization
 {
-    [Serializable]
     internal enum BidiCategory
     {
         LeftToRight = 0,
diff --git a/src/mscorlib/src/System/Globalization/CompareInfo.cs b/src/mscorlib/src/System/Globalization/CompareInfo.cs
@@ -20,7 +20,6 @@
 namespace System.Globalization
 {
     [Flags]
-    [Serializable]
     public enum CompareOptions
     {
         None = 0x00000000,
diff --git a/src/mscorlib/src/System/IO/SearchOption.cs b/src/mscorlib/src/System/IO/SearchOption.cs
@@ -20,7 +20,6 @@
 
 namespace System.IO
 {
-    [Serializable]
     internal enum SearchOption
     {
         // Include only the current directory in the search operation
diff --git a/src/mscorlib/src/System/Reflection/CustomAttribute.cs b/src/mscorlib/src/System/Reflection/CustomAttribute.cs
@@ -965,7 +965,6 @@ internal struct CustomAttributeRecord
         internal MetadataToken tkCtor;
     }
 
-    [Serializable]
     internal enum CustomAttributeEncoding : int
     {
         Undefined = 0,
diff --git a/src/mscorlib/src/System/Reflection/Emit/AssemblyBuilderAccess.cs b/src/mscorlib/src/System/Reflection/Emit/AssemblyBuilderAccess.cs
@@ -9,7 +9,6 @@
 
 namespace System.Reflection.Emit
 {
-    [Serializable]
     [Flags]
     public enum AssemblyBuilderAccess
     {
diff --git a/src/mscorlib/src/System/Reflection/Emit/FlowControl.cs b/src/mscorlib/src/System/Reflection/Emit/FlowControl.cs
@@ -16,7 +16,6 @@
 
 namespace System.Reflection.Emit
 {
-    [Serializable]
     public enum FlowControl
     {
         Branch = 0,
diff --git a/src/mscorlib/src/System/Reflection/Emit/ILGenerator.cs b/src/mscorlib/src/System/Reflection/Emit/ILGenerator.cs
@@ -1605,7 +1605,6 @@ internal int GetCurrentState()
     * takes place.
     *
     ***************************/
-    [Serializable]
     internal enum ScopeAction
     {
         Open = 0x0,
diff --git a/src/mscorlib/src/System/Reflection/Emit/OpcodeType.cs b/src/mscorlib/src/System/Reflection/Emit/OpcodeType.cs
@@ -17,7 +17,6 @@
 
 namespace System.Reflection.Emit
 {
-    [Serializable]
     public enum OpCodeType
     {
         [Obsolete("This API has been deprecated. http://go.microsoft.com/fwlink/?linkid=14202")]
diff --git a/src/mscorlib/src/System/Reflection/Emit/OperandType.cs b/src/mscorlib/src/System/Reflection/Emit/OperandType.cs
@@ -17,7 +17,6 @@
 
 namespace System.Reflection.Emit
 {
-    [Serializable]
     public enum OperandType
     {
         InlineBrTarget = 0,
diff --git a/src/mscorlib/src/System/Reflection/Emit/PEFileKinds.cs b/src/mscorlib/src/System/Reflection/Emit/PEFileKinds.cs
@@ -8,7 +8,6 @@
 namespace System.Reflection.Emit
 {
     // This Enum matchs the CorFieldAttr defined in CorHdr.h
-    [Serializable]
     public enum PEFileKinds
     {
         Dll = 0x0001,
diff --git a/src/mscorlib/src/System/Reflection/Emit/StackBehaviour.cs b/src/mscorlib/src/System/Reflection/Emit/StackBehaviour.cs
@@ -17,7 +17,6 @@
 
 namespace System.Reflection.Emit
 {
-    [Serializable]
     public enum StackBehaviour
     {
         Pop0 = 0,
diff --git a/src/mscorlib/src/System/Reflection/Emit/SymbolType.cs b/src/mscorlib/src/System/Reflection/Emit/SymbolType.cs
@@ -12,7 +12,6 @@ namespace System.Reflection.Emit
     using System.Diagnostics.Contracts;
     using CultureInfo = System.Globalization.CultureInfo;
 
-    [Serializable]
     internal enum TypeKind
     {
         IsArray = 1,
diff --git a/src/mscorlib/src/System/Reflection/Emit/TypeBuilder.cs b/src/mscorlib/src/System/Reflection/Emit/TypeBuilder.cs
@@ -20,7 +20,6 @@ namespace System.Reflection.Emit
     using System.Diagnostics.Contracts;
 
 
-    [Serializable]
     public enum PackingSize
     {
         Unspecified = 0,
diff --git a/src/mscorlib/src/System/Reflection/MdImport.cs b/src/mscorlib/src/System/Reflection/MdImport.cs
@@ -20,7 +20,6 @@
 
 namespace System.Reflection
 {
-    [Serializable]
     internal enum CorElementType : byte
     {
         End = 0x00,
@@ -61,7 +60,6 @@ internal enum CorElementType : byte
         Pinned = 0x45,
     }
 
-    [Serializable]
     [Flags()]
     internal enum MdSigCallingConvention : byte
     {
@@ -85,7 +83,6 @@ internal enum MdSigCallingConvention : byte
     }
 
 
-    [Serializable]
     [Flags()]
     internal enum PInvokeAttributes
     {
@@ -122,7 +119,6 @@ internal enum PInvokeAttributes
     }
 
 
-    [Serializable]
     [Flags()]
     internal enum MethodSemanticsAttributes
     {
@@ -135,7 +131,6 @@ internal enum MethodSemanticsAttributes
     }
 
 
-    [Serializable]
     internal enum MetadataTokenType
     {
         Module = 0x00000000,
diff --git a/src/mscorlib/src/System/Runtime/GcSettings.cs b/src/mscorlib/src/System/Runtime/GcSettings.cs
@@ -13,14 +13,12 @@ namespace System.Runtime
     // These settings are the same format as in clr\src\vm\gcpriv.h
     // make sure you change that file if you change this file!
 
-    [Serializable]
     public enum GCLargeObjectHeapCompactionMode
     {
         Default = 1,
         CompactOnce = 2
     }
 
-    [Serializable]
     public enum GCLatencyMode
     {
         Batch = 0,
diff --git a/src/mscorlib/src/System/Runtime/InteropServices/Attributes.cs b/src/mscorlib/src/System/Runtime/InteropServices/Attributes.cs
@@ -46,7 +46,6 @@ public DispIdAttribute(int dispId)
         public int Value { get { return _val; } }
     }
 
-    [Serializable]
     public enum ComInterfaceType
     {
         InterfaceIsDual = 0,
@@ -84,7 +83,6 @@ public ComDefaultInterfaceAttribute(Type defaultInterface)
         public Type Value { get { return _val; } }
     }
 
-    [Serializable]
     public enum ClassInterfaceType
     {
         None = 0,
diff --git a/src/mscorlib/src/System/Runtime/InteropServices/ComMemberType.cs b/src/mscorlib/src/System/Runtime/InteropServices/ComMemberType.cs
@@ -9,7 +9,6 @@
 
 namespace System.Runtime.InteropServices
 {
-    [Serializable]
     public enum ComMemberType
     {
         Method = 0,
diff --git a/src/mscorlib/src/System/Runtime/InteropServices/ComTypes/ITypeComp.cs b/src/mscorlib/src/System/Runtime/InteropServices/ComTypes/ITypeComp.cs
diff --git a/src/mscorlib/src/System/Runtime/InteropServices/ComTypes/ITypeInfo.cs b/src/mscorlib/src/System/Runtime/InteropServices/ComTypes/ITypeInfo.cs
diff --git a/src/mscorlib/src/System/Runtime/InteropServices/ComTypes/ITypeLib.cs b/src/mscorlib/src/System/Runtime/InteropServices/ComTypes/ITypeLib.cs
diff --git a/src/mscorlib/src/System/Runtime/InteropServices/GcHandle.cs b/src/mscorlib/src/System/Runtime/InteropServices/GcHandle.cs
diff --git a/src/mscorlib/src/System/Runtime/InteropServices/ICustomQueryInterface.cs b/src/mscorlib/src/System/Runtime/InteropServices/ICustomQueryInterface.cs
diff --git a/src/mscorlib/src/System/Runtime/InteropServices/Marshal.cs b/src/mscorlib/src/System/Runtime/InteropServices/Marshal.cs
diff --git a/src/mscorlib/src/System/Runtime/InteropServices/PInvokeMap.cs b/src/mscorlib/src/System/Runtime/InteropServices/PInvokeMap.cs
diff --git a/src/mscorlib/src/System/Threading/Tasks/Task.cs b/src/mscorlib/src/System/Threading/Tasks/Task.cs
diff --git a/src/mscorlib/src/System/Threading/Thread.cs b/src/mscorlib/src/System/Threading/Thread.cs

Original file line number	Diff line number	Diff line change
`@@ -12,6 +12,5 @@`
`12`	`12`
`13`	`13`	`namespace System`
`14`	`14`	`{`
`15`		`- [Serializable]`
`16`	`15`	`public delegate void AsyncCallback(IAsyncResult ar);`
`17`	`16`	`}`
Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,6 @@ namespace System`
`10`	`10`	`// Enum used to indicate all the elements of the`
`11`	`11`	`// VOS it is valid to attach this element to.`
`12`	`12`	`[Flags]`
`13`		`- [Serializable]`
`14`	`13`	`public enum AttributeTargets`
`15`	`14`	`{`
`16`	`15`	`Assembly = 0x0001,`
Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,6 @@ namespace System`
`7`	`7`	`// This enum is used to indentify DateTime instances in cases when they are known to be in local time,`
`8`	`8`	`// UTC time or if this information has not been specified or is not applicable.`
`9`	`9`
`10`		`- [Serializable]`
`11`	`10`	`public enum DateTimeKind`
`12`	`11`	`{`
`13`	`12`	`Unspecified = 0,`
Original file line number	Diff line number	Diff line change
`@@ -13,7 +13,6 @@`
`13`	`13`
`14`	`14`	`namespace System`
`15`	`15`	`{`
`16`		`- [Serializable]`
`17`	`16`	`public enum DayOfWeek`
`18`	`17`	`{`
`19`	`18`	`Sunday = 0,`
Original file line number	Diff line number	Diff line change
`@@ -6,9 +6,7 @@`
`6`	`6`
`7`	`7`	`namespace System`
`8`	`8`	`{`
`9`		`- [Serializable]`
`10`	`9`	`public delegate void EventHandler(Object sender, EventArgs e);`
`11`	`10`
`12`		`- [Serializable]`
`13`	`11`	`public delegate void EventHandler<TEventArgs>(Object sender, TEventArgs e); // Removed TEventArgs constraint post-.NET 4`
`14`	`12`	`}`
Original file line number	Diff line number	Diff line change
`@@ -4,7 +4,6 @@`
`4`	`4`
`5`	`5`	`namespace System.Globalization`
`6`	`6`	`{`
`7`		`- [Serializable]`
`8`	`7`	`public enum CalendarWeekRule`
`9`	`8`	`{`
`10`	`9`	`FirstDay = 0, // Week 1 begins on the first day of the year`
Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,6 @@ namespace System.Globalization`
`6`	`6`	`{`
`7`	`7`	`// Note: The values of the members of this enum must match the coresponding values`
`8`	`8`	`// in the CalendarId enum (since we cast between GregorianCalendarTypes and CalendarId).`
`9`		`- [Serializable]`
`10`	`9`	`public enum GregorianCalendarTypes`
`11`	`10`	`{`
`12`	`11`	`Localized = CalendarId.GREGORIAN,`
Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,6 @@ namespace System.IO`
`9`	`9`	`// Contains constants for specifying the access you want for a file.`
`10`	`10`	`// You can have Read, Write or ReadWrite access.`
`11`	`11`	`//`
`12`		`- [Serializable]`
`13`	`12`	`[Flags]`
`14`	`13`	`public enum FileAccess`
`15`	`14`	`{`
Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,6 @@ namespace System.Runtime.CompilerServices`
`6`	`6`	`{`
`7`	`7`	`/// IMPORTANT: Keep this in sync with corhdr.h`
`8`	`8`	`[Flags]`
`9`		`- [Serializable]`
`10`	`9`	`public enum CompilationRelaxations : int`
`11`	`10`	`{`
`12`	`11`	`NoStringInterning = 0x0008 // Start in 0x0008, we had other non public flags in this enum before,`
Original file line number	Diff line number	Diff line change
`@@ -4,7 +4,6 @@`
`4`	`4`
`5`	`5`	`namespace System.Runtime.CompilerServices`
`6`	`6`	`{`
`7`		`- [Serializable]`
`8`	`7`	`public enum LoadHint`
`9`	`8`	`{`
`10`	`9`	`Default = 0x0000, // No preference specified`