Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Commit b230709

Browse files
DrewScogginsgkhanna79
authored andcommitted
Fix performance runs (#11727)
* Disable Musicstore from ILLink test MusicStore is currently a very flaky scenario so for now I am disabling the MusicStore test of ILLink. We will add this back when we move this scenario test over to its own leg. * Fix Performance Runs This fixes the performance runs to work with the new 2.0 build tools package that we just took.
1 parent 51329bd commit b230709

File tree

2 files changed

+7
-10
lines changed

2 files changed

+7
-10
lines changed
Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,11 @@
1-
<?xml version="1.0" encoding="utf-8"?>
2-
<Project ToolsVersion="12.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
1+
<Project Sdk="Microsoft.NET.Sdk">
32
<PropertyGroup>
4-
<OutputType>Exe</OutputType>
5-
<TargetFramework>netcoreapp1.1</TargetFramework>
3+
<OutputType>exe</OutputType>
4+
<TargetFramework>netcoreapp2.0</TargetFramework>
65
</PropertyGroup>
76
<ItemGroup>
87
<PackageReference Include="xunit.performance.api">
98
<Version>1.0.0-beta-build0003</Version>
109
</PackageReference>
11-
<PackageReference Include="Microsoft.NETCore.App">
12-
<Version>1.1.0</Version>
13-
</PackageReference>
1410
</ItemGroup>
15-
</Project>
11+
</Project>

tests/src/performance/linkbench/linkbench.cs

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -251,14 +251,15 @@ public class LinkBench
251251
"WebAPI\\bin\\release\\netcoreapp2.0\\win10-x64\\linked",
252252
() => { Benchmark.AddLinkerReference("WebAPI\\WebAPI.csproj");
253253
Benchmark.PreventPublishFiltering("WebAPI\\WebAPI.csproj"); }),
254-
new Benchmark("MusicStore",
254+
//Remove the MusicStore from the run as the scenario is currently flaky and breaking performance runs
255+
/*new Benchmark("MusicStore",
255256
"JitBench\\src\\MusicStore\\bin\\release\\netcoreapp2.0\\win10-x64\\unlinked",
256257
"JitBench\\src\\MusicStore\\bin\\release\\netcoreapp2.0\\win10-x64\\linked",
257258
() => { Benchmark.AddLinkerReference("JitBench\\src\\MusicStore\\MusicStore.csproj");
258259
Benchmark.SetRuntimeFrameworkVersion("JitBench\\src\\MusicStore\\MusicStore.csproj"); }),
259260
new Benchmark("MusicStore_R2R",
260261
"JitBench\\src\\MusicStore\\bin\\release\\netcoreapp2.0\\win10-x64\\R2R\\unlinked",
261-
"JitBench\\src\\MusicStore\\bin\\release\\netcoreapp2.0\\win10-x64\\R2R\\linked"),
262+
"JitBench\\src\\MusicStore\\bin\\release\\netcoreapp2.0\\win10-x64\\R2R\\linked"),*/
262263
new Benchmark("Corefx",
263264
"corefx\\bin\\ILLinkTrimAssembly\\netcoreapp-Windows_NT-Release-x64\\pretrimmed",
264265
"corefx\\bin\\ILLinkTrimAssembly\\netcoreapp-Windows_NT-Release-x64\\trimmed"),

0 commit comments

Comments
 (0)