Resolve race in ShimProxyCallback::AddRef (#15643)

benaadams · jkotas · commit f8153eaaf918 · 2017-12-27T08:12:14.000-08:00
diff --git a/src/debug/di/shimcallback.cpp b/src/debug/di/shimcallback.cpp
@@ -31,8 +31,7 @@ ShimProxyCallback::ShimProxyCallback(ShimProcess * pShim)
 // Implement IUnknown
 ULONG ShimProxyCallback::AddRef()
 {
-    InterlockedIncrement(&m_cRef);
-    return m_cRef;
+    return InterlockedIncrement(&m_cRef);
 }
 ULONG ShimProxyCallback::Release()
 {

Original file line number	Diff line number	Diff line change
`@@ -31,8 +31,7 @@ ShimProxyCallback::ShimProxyCallback(ShimProcess * pShim)`
`31`	`31`	`// Implement IUnknown`
`32`	`32`	`ULONG ShimProxyCallback::AddRef()`
`33`	`33`	`{`
`34`		`- InterlockedIncrement(&m_cRef);`
`35`		`- return m_cRef;`
	`34`	`+ return InterlockedIncrement(&m_cRef);`
`36`	`35`	`}`
`37`	`36`	`ULONG ShimProxyCallback::Release()`
`38`	`37`	`{`