Specify the minimum supported version of macOS #21816
Conversation
|
@janvorli Can you please take a look at the changes in configurecompiler.cmake? |
|
It is great that there is a way to build for older macOS version on newer ones! When you've tested it, have you tried to actually run a version built on 10.14 on 10.12? The comment #10 in the https://stackoverflow.com/questions/2923502/what-does-macosx-version-min-imply seems to indicate that the option needs to be passed to linker too. |
|
@janvorli I've tried on 1012 and 1013 only. I will try to run it on 1014 as well and make sure the option passed to linker. Thanks! |
|
Whatever the build runs on, we should be testing on 10.12 and 10.14 (as highest and lowest) and ideally 10.13 as well. CoreFX tests on all of them. CoreCLR does not seem to run tests on 10.14 judging by mission control at least. @jashook ? |
|
I have confirmed that this solution would work on all three versions of OSX: 10.12, 10.13, 10.14 |
|
@danmosemsft We will be running internal tests on all three OSX versions in AzDO (as soon as this got merged). For open project (running against a PR) - only OSX.1012 and OSX.1013 open queues are available. |
|
@janvorli Can you please confirm that the changes to pass the option to linker look good? |
|
@MattGal Am I right that there is no "OSX.1014.Amd64.Open" queue we can utilize? |
|
@echesakov there's a limited number of machines, but we do have them so I stood it up (https://helix.dot.net/api/2018-03-14/info/queues/osx.1014.amd64.open ) https://dnceng.visualstudio.com/internal/_git/dotnet-helix-machines/pullrequest/381 tracks getting this to be a permanent change. |
|
@MattGal I see, thanks. Since there's a limited number of machines can I use this queue to run tests against each PR or not? |
|
I'd recommend against it for all PRs, but you can definitely scout it; if you have an active need for it let me know and I can work with @ilyas1974 about when we can get more machines. ** Edit: Actually if it's just running tests and not builds, this is probably enough machines, just be ready to back it out if I'm wrong. |
* Pass the minimum supported version of macOS option to both compile and link stages in configurecompiler.cmake * Enable OSX.1012.Amd64.* open and internal queues and add OSX.1014.Amd64 queue in eng/platform-matrix.yml Commit migrated from dotnet/coreclr@fe5f8d6
5 participants
As suggested in #21642 (comment) specify the minimum supported version of macOS to make coreclr built on macOS 10.13 work on macOS 10.12 and later
Tested in https://dnceng.visualstudio.com/public/_build/results?buildId=66785 and https://dnceng.visualstudio.com/public/_build/results?buildId=66781