Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Conversation

jkotas
Copy link
Member

@jkotas jkotas commented Mar 16, 2016

No description provided.

@jkotas
Copy link
Member Author

jkotas commented Mar 16, 2016

@wtgodbe @AndyAyersMS These two tests are failing in all CI jobs. How do I disable them until they are fixed? Adding them to testsFailingOutsideWindows.txt does not seem to have effect.

GC/Regressions/dev10bugs/536168/536168/536168.sh

JIT/Regression/CLR-x86-EJIT/V1-M09.5-PDC/b14426/b14426.sh
JIT/Performance/CodeQuality/BenchmarksGame/pidigits/pi-digits.sh
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need an extra pi-digits in there, eg

JIT/Performance/CodeQuality/BenchmarksGame/pidigits/pi-digits/pi-digits.sh

probably similar fixup for the other test.

Is there an issue open so we can get the underlying problem fixed?

@wtgodbe
Copy link
Member

wtgodbe commented Mar 16, 2016

Andy is correct - it should be

JIT/Regression/CLR-x86-EJIT/V1-M09.5-PDC/b14426/b14426/b14426.sh JIT/Performance/CodeQuality/BenchmarksGame/pidigits/pi-digits/pi-digits.sh

Since when the tests are built, each .csproj creates a folder inside the current folder with the name of the test - so if 'pi-digits.csproj' is inside a folder named pidigits, pi-digits.sh will be inside a folder named pi-digits inside of pidigits.

@AndyAyersMS I opened this issue to track these (https://github.com/dotnet/coreclr/issues/3664), I'll add these 2 to the list.

@jkotas
Copy link
Member Author

jkotas commented Mar 16, 2016

I have fixed up the test paths. Thanks!

@jkotas jkotas mentioned this pull request Mar 16, 2016
jkotas added a commit that referenced this pull request Mar 16, 2016
Disable tests that are failing in CI on Unix
@jkotas jkotas merged commit ad7b11b into dotnet:master Mar 16, 2016
@gkhanna79
Copy link
Member

These failures are being tracked by https://github.com/dotnet/coreclr/issues/3763

@jkotas jkotas deleted the failing-tests branch March 20, 2016 04:04
picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022
Disable tests that are failing in CI on Unix

Commit migrated from dotnet/coreclr@ad7b11b
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants