clean GetHostByAddr Windows

Author: MarcoRossignoli

src/Common/src/Interop/Windows/Winsock/Interop.gethostbyaddr.cs

@@ -94,10 +94,7 @@
     </Compile>
     <Compile Include="$(CommonPath)\Interop\Windows\Winsock\Interop.closesocket.cs">
       <Link>Interop\Windows\Winsock\Interop.closesocket.cs</Link>
-    </Compile>
-    <Compile Include="$(CommonPath)\Interop\Windows\Winsock\Interop.gethostbyaddr.cs">
-      <Link>Interop\Windows\Winsock\Interop.gethostbyaddr.cs</Link>
-    </Compile>
+    </Compile>    
     <Compile Include="$(CommonPath)\Interop\Windows\Winsock\Interop.gethostname.cs">
       <Link>Interop\Windows\Winsock\Interop.gethostname.cs</Link>
     </Compile>
@@ -212,4 +209,4 @@
     <Reference Include="System.Threading.Tasks" />
   </ItemGroup>
   <Import Project="$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory), dir.targets))\dir.targets" />
-</Project>
+</Project>

src/System.Net.NameResolution/src/System.Net.NameResolution.csproj

@@ -156,34 +156,6 @@ private static IPHostEntry NativeToHostEntry(IntPtr nativePointer)
             return HostEntry;
         } // NativeToHostEntry
 
-        public static IPHostEntry GetHostByAddr(IPAddress address)
-        {
-            // TODO #2891: Optimize this (or decide if this legacy code can be removed):
-#pragma warning disable CS0618 // Address is marked obsolete
-            int addressAsInt = unchecked((int)address.Address);
-#pragma warning restore CS0618
-
-#if BIGENDIAN
-            // TODO #2891: above code needs testing for BIGENDIAN.
-
-            addressAsInt = (int)(((uint)addressAsInt << 24) | (((uint)addressAsInt & 0x0000FF00) << 8) |
-                (((uint)addressAsInt >> 8) & 0x0000FF00) | ((uint)addressAsInt >> 24));
-#endif
-
-            IntPtr nativePointer =
-                Interop.Winsock.gethostbyaddr(
-                    ref addressAsInt,
-                    sizeof(int),
-                    ProtocolFamily.InterNetwork);
-            
-            if (nativePointer != IntPtr.Zero)
-            {
-                return NativeToHostEntry(nativePointer);
-            }
-
-            throw new SocketException();
-        }
-
         public static unsafe SocketError TryGetAddrInfo(string name, out IPHostEntry hostinfo, out int nativeErrorCode)
         {
             //

src/System.Net.NameResolution/src/System/Net/NameResolutionPal.Windows.cs

@@ -22,12 +22,6 @@ public void HostName_NotNull()
             Assert.NotNull(NameResolutionPal.GetHostName());
         }
 
-        [Fact]
-        public void GetHostByAddr_LocalHost()
-        {
-            Assert.NotNull(NameResolutionPal.GetHostByAddr(new IPAddress(0x0100007f)));
-        }
-
         [Fact]
         public void TryGetAddrInfo_LocalHost()
         {

src/System.Net.NameResolution/tests/PalTests/NameResolutionPalTests.cs

@@ -95,9 +95,6 @@
     </Compile>
     <Compile Include="$(CommonPath)\Interop\Windows\Winsock\Interop.closesocket.cs">
       <Link>Interop\Windows\Winsock\Interop.closesocket.cs</Link>
-    </Compile>
-    <Compile Include="$(CommonPath)\Interop\Windows\Winsock\Interop.gethostbyaddr.cs">
-      <Link>Interop\Windows\Winsock\Interop.gethostbyaddr.cs</Link>
     </Compile>    
     <Compile Include="$(CommonPath)\Interop\Windows\Winsock\Interop.gethostname.cs">
       <Link>Interop\Windows\Winsock\Interop.gethostname.cs</Link>
@@ -193,4 +190,4 @@
     </Compile>
   </ItemGroup>
   <Import Project="$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory), dir.targets))\dir.targets" />
-</Project>
+</Project>