Use non-inlineable overload for rare CompareOrdinalIgnoreCase path (#17492)

jkotas · jkotas · commit 1f665aad7a42 · 2018-04-10T12:58:07.000-07:00
This fixes regression introduced in #17237. Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
diff --git a/src/Common/src/CoreLib/System/String.Comparison.cs b/src/Common/src/CoreLib/System/String.Comparison.cs
@@ -317,7 +317,7 @@ public static int Compare(string strA, string strB, StringComparison comparisonT
                         return CompareOrdinalIgnoreCaseHelper(strA, strB);
                     }
 #endif
-                    return CompareInfo.CompareOrdinalIgnoreCase(strA, strB);
+                    return CompareInfo.CompareOrdinalIgnoreCase(strA, 0, strA.Length, strB, 0, strB.Length);
 
                 default:
                     throw new ArgumentException(SR.NotSupported_StringComparison, nameof(comparisonType));

Original file line number	Diff line number	Diff line change
`@@ -317,7 +317,7 @@ public static int Compare(string strA, string strB, StringComparison comparisonT`
`317`	`317`	`return CompareOrdinalIgnoreCaseHelper(strA, strB);`
`318`	`318`	`}`
`319`	`319`	`#endif`
`320`		`- return CompareInfo.CompareOrdinalIgnoreCase(strA, strB);`
	`320`	`+ return CompareInfo.CompareOrdinalIgnoreCase(strA, 0, strA.Length, strB, 0, strB.Length);`
`321`	`321`
`322`	`322`	`default:`
`323`	`323`	`throw new ArgumentException(SR.NotSupported_StringComparison, nameof(comparisonType));`