Avoid boxing allocation from PtrToStructure in UnmanagedCertificateContext

stephentoub · stephentoub · commit 2a1d9413cc15 · 2018-03-16T10:58:10.000-04:00
diff --git a/src/Common/src/Interop/Windows/SChannel/UnmanagedCertificateContext.IntPtr.cs b/src/Common/src/Interop/Windows/SChannel/UnmanagedCertificateContext.IntPtr.cs
@@ -20,8 +20,11 @@ internal static X509Certificate2Collection GetRemoteCertificatesFromStoreContext
                 return result;
             }
 
-            Interop.Crypt32.CERT_CONTEXT context =
-                Marshal.PtrToStructure<Interop.Crypt32.CERT_CONTEXT>(certContext);
+            Interop.Crypt32.CERT_CONTEXT context;
+            unsafe
+            {
+                context = *(Interop.Crypt32.CERT_CONTEXT*)certContext;
+            }
 
             if (context.hCertStore != IntPtr.Zero)
             {

Original file line number	Diff line number	Diff line change
`@@ -20,8 +20,11 @@ internal static X509Certificate2Collection GetRemoteCertificatesFromStoreContext`
`20`	`20`	`return result;`
`21`	`21`	`}`
`22`	`22`
`23`		`- Interop.Crypt32.CERT_CONTEXT context =`
`24`		`- Marshal.PtrToStructure<Interop.Crypt32.CERT_CONTEXT>(certContext);`
	`23`	`+ Interop.Crypt32.CERT_CONTEXT context;`
	`24`	`+ unsafe`
	`25`	`+ {`
	`26`	`+ context = (Interop.Crypt32.CERT_CONTEXT)certContext;`
	`27`	`+ }`
`25`	`28`
`26`	`29`	`if (context.hCertStore != IntPtr.Zero)`
`27`	`30`	`{`