This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Commit 2d420dd
committed
Disable OOBing for Vectors on NCA2.1 and UAP6+
Fixes #26834
Vectors forwards types to S.P.C but we were oobing the non-facade implementation assembly.
As a result, when using the package we switch from using type-forwards to using the types
defined in the assembly. This will break type unification.
We can decide to either:
1. Put placeholders in the package and effectively freeze the API.
2. Put the partial facades in the package.
System.Buffers had a similar problem and we decided to use placeholders. It was slightly different since it was a full facade.
The pro of going with 1 is that it simplifies the build. The con is that it freezes the API:
future additions would need to be in a new netstandard version. Additionally it means
that new packages can't deliver bugfixes out-of-band.
We can always unfreeze the API in the future by bringing back a live build for netcoreapp2.1
that builds against S.P.C. This allows us to effectively switch to 2 *as needed*.
As a result I will go with option1.1 parent fd7048c commit 2d420dd
File tree
1 file changed
+2
-9
lines changed- src/System.Numerics.Vectors/pkg
1 file changed
+2
-9
lines changedLines changed: 2 additions & 9 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
21 | 21 | | |
22 | 22 | | |
23 | 23 | | |
24 | | - | |
25 | | - | |
26 | | - | |
27 | | - | |
28 | | - | |
29 | | - | |
30 | | - | |
31 | | - | |
32 | | - | |
| 24 | + | |
| 25 | + | |
33 | 26 | | |
34 | 27 | | |
35 | 28 | | |
0 commit comments