Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Commit 2d420dd

Browse files
committed
Disable OOBing for Vectors on NCA2.1 and UAP6+
Fixes #26834 Vectors forwards types to S.P.C but we were oobing the non-facade implementation assembly. As a result, when using the package we switch from using type-forwards to using the types defined in the assembly. This will break type unification. We can decide to either: 1. Put placeholders in the package and effectively freeze the API. 2. Put the partial facades in the package. System.Buffers had a similar problem and we decided to use placeholders. It was slightly different since it was a full facade. The pro of going with 1 is that it simplifies the build. The con is that it freezes the API: future additions would need to be in a new netstandard version. Additionally it means that new packages can't deliver bugfixes out-of-band. We can always unfreeze the API in the future by bringing back a live build for netcoreapp2.1 that builds against S.P.C. This allows us to effectively switch to 2 *as needed*. As a result I will go with option1.
1 parent fd7048c commit 2d420dd

File tree

1 file changed

+2
-9
lines changed

1 file changed

+2
-9
lines changed

src/System.Numerics.Vectors/pkg/System.Numerics.Vectors.pkgproj

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -21,15 +21,8 @@
2121
<InboxOnTargetFramework Include="xamarinmac20" />
2222
<InboxOnTargetFramework Include="xamarintvos10" />
2323
<InboxOnTargetFramework Include="xamarinwatchos10" />
24-
25-
<!-- Since UAP and .NETCoreApp are package based we still want to enable
26-
OOBing libraries that happen to overlap with their framework package.
27-
This avoids us having to lock the API in our NuGet packages just
28-
to match what shipped inbox: since we can provide a new library
29-
we can update it to add API without raising the netstandard version. -->
30-
<ValidatePackageSuppression Include="TreatAsOutOfBox">
31-
<Value>.NETCoreApp;UAP</Value>
32-
</ValidatePackageSuppression>
24+
<InboxOnTargetFramework Include="netcoreapp2.1" />
25+
<InboxOnTargetFramework Include="uap10.0.16299" />
3326
</ItemGroup>
3427
<Import Project="$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory), dir.targets))\dir.targets" />
3528
</Project>

0 commit comments

Comments
 (0)