Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Commit 2ee63c6

Browse files
AlexRadchstephentoub
authored andcommitted
System.IO.FileSystem.AccessControl.Tests fails some tests on non english windows (#27628)
1 parent 52b6280 commit 2ee63c6

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

src/System.IO.FileSystem.AccessControl/tests/FileSystemSecurityTests.cs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ public void AddAccessRule_Succeeds()
3333
fileSecurity.GetAccessRules(true, true, typeof(System.Security.Principal.NTAccount));
3434
Assert.Equal(1, rules.Count);
3535
var actualAddedRule = (FileSystemAccessRule)rules[0];
36-
Assert.Equal(accessRule.IdentityReference, actualAddedRule.IdentityReference);
36+
Assert.Equal(new SecurityIdentifier(WellKnownSidType.LocalSystemSid, null).Translate(typeof(NTAccount)), actualAddedRule.IdentityReference);
3737
Assert.Equal(accessRule.FileSystemRights, actualAddedRule.FileSystemRights);
3838
Assert.Equal(accessRule.AccessControlType, actualAddedRule.AccessControlType);
3939
}
@@ -81,7 +81,7 @@ public void SetAccessRule_IgnoreExistingRule_Succeeds()
8181

8282
Assert.Equal(2, rules.Count);
8383
var existingAccessRule = (FileSystemAccessRule)rules[0];
84-
Assert.Equal(new NTAccount(@"NT AUTHORITY\SYSTEM"), existingAccessRule.IdentityReference);
84+
Assert.Equal(new SecurityIdentifier(WellKnownSidType.LocalSystemSid, null).Translate(typeof(NTAccount)), existingAccessRule.IdentityReference);
8585
existingAccessRule = (FileSystemAccessRule)rules[1];
8686
Assert.Equal(new NTAccount(@"NT AUTHORITY\Network Service"), existingAccessRule.IdentityReference);
8787
}
@@ -256,7 +256,7 @@ public void RemoveAccessRuleAll_Succeeds()
256256

257257
Assert.Equal(2, rules.Count);
258258
var existingAccessRule = (FileSystemAccessRule)rules[0];
259-
Assert.Equal(new NTAccount(@"NT AUTHORITY\SYSTEM"), existingAccessRule.IdentityReference);
259+
Assert.Equal(new SecurityIdentifier(WellKnownSidType.LocalSystemSid, null).Translate(typeof(NTAccount)), existingAccessRule.IdentityReference);
260260
Assert.Equal(AccessControlType.Deny, existingAccessRule.AccessControlType);
261261
Assert.Equal(FileSystemRights.ReadPermissions, existingAccessRule.FileSystemRights);
262262
existingAccessRule = (FileSystemAccessRule)rules[1];
@@ -286,7 +286,7 @@ public void AddAuditRule_Succeeds()
286286
fileSecurity.GetAuditRules(true, true, typeof(System.Security.Principal.NTAccount));
287287
Assert.Equal(1, auditRules.Count);
288288
var actualAddedRule = (FileSystemAuditRule)auditRules[0];
289-
Assert.Equal(new NTAccount(@"NT AUTHORITY\SYSTEM"), actualAddedRule.IdentityReference);
289+
Assert.Equal(new SecurityIdentifier(WellKnownSidType.LocalSystemSid, null).Translate(typeof(NTAccount)), actualAddedRule.IdentityReference);
290290
Assert.Equal(AuditFlags.Success, actualAddedRule.AuditFlags);
291291
Assert.Equal(FileSystemRights.AppendData, actualAddedRule.FileSystemRights);
292292
}
@@ -309,7 +309,7 @@ public void SetAuditRule_Succeeds()
309309

310310
Assert.Equal(2, auditRules.Count);
311311
var firstAuditRule = (FileSystemAuditRule)auditRules[0];
312-
Assert.Equal(new NTAccount(@"NT AUTHORITY\SYSTEM"), firstAuditRule.IdentityReference);
312+
Assert.Equal(new SecurityIdentifier(WellKnownSidType.LocalSystemSid, null).Translate(typeof(NTAccount)), firstAuditRule.IdentityReference);
313313
Assert.Equal(AuditFlags.Success, firstAuditRule.AuditFlags);
314314
Assert.Equal(FileSystemRights.Delete, firstAuditRule.FileSystemRights);
315315
var secondAuditRule = (FileSystemAuditRule)auditRules[1];
@@ -337,7 +337,7 @@ public void RemoveAuditRule_Succeeds()
337337
var existingRule = (FileSystemAuditRule)rules[0];
338338
Assert.Equal(FileSystemRights.Read, existingRule.FileSystemRights);
339339
Assert.Equal(AuditFlags.Failure, existingRule.AuditFlags);
340-
Assert.Equal(new NTAccount(@"NT AUTHORITY\SYSTEM"), existingRule.IdentityReference);
340+
Assert.Equal(new SecurityIdentifier(WellKnownSidType.LocalSystemSid, null).Translate(typeof(NTAccount)), existingRule.IdentityReference);
341341
}
342342

343343
[Fact]

0 commit comments

Comments
 (0)