Fix rd.xml for Serialization Reflection Only Mode. (#19556)

* Fix rd.xml for Serialization Reflection Only Mode.

Fix #19067

* Removed GenericParameter Entries.

Author: shmao

src/System.Private.DataContractSerialization/src/Resources/System.Private.DataContractSerialization.rd.xml

@@ -10,6 +10,28 @@
           </Method>
         </Type>
         <Type Name="KeyValuePairAdapter`2" Dynamic="Required All" />
+        <!-- Reflection-based serialization requires the entries below. -->
+        <Type Name="CollectionDataContract">
+          <Type Name="CollectionDataContractCriticalHelper">
+            <Method Name="BuildCreateGenericDictionaryEnumerator{K, V}" Dynamic="Required" />
+            <Method Name="BuildIncrementCollectionCountDelegate{T}" Dynamic="Required" />
+          </Type>
+        </Type>
+        <Type Name="DataContractSerializer">
+          <Property Name="Option" Dynamic="Required" />
+        </Type>
+        <Type Name="FastInvokerBuilder" Dynamic="Required All" />
+        <Type Name="ReflectionReader">
+          <Method Name="GetCollectionSetItemDelegate{T}" Dynamic="Required" />
+          <Method Name="ObjectToKeyValuePairGetKey{K, V}" Dynamic="Required" />
+          <Method Name="ObjectToKeyValuePairGetValue{K, V}" Dynamic="Required" />
+        </Type>
+        <Type Name="XmlObjectSerializerReadContext">
+          <Method Name="TrimArraySize{T}" Dynamic="Required" />
+        </Type>
+        <Type Name="XmlObjectSerializerWriteContext">        
+          <Method Name="GetDefaultValue{T}" Dynamic="Required" />
+        </Type>
       </Namespace>
       <Namespace Name="System.Runtime.Serialization.Json">
         <Type Name="DataContractJsonSerializer">

src/System.Private.DataContractSerialization/src/System/Runtime/Serialization/CollectionDataContract.cs

@@ -438,7 +438,12 @@ internal XmlFormatGetOnlyCollectionReaderDelegate XmlFormatGetOnlyCollectionRead
                             {
                                 throw DiagnosticUtility.ExceptionUtility.ThrowHelperError(new InvalidDataContractException(SR.Format(SR.GetOnlyCollectionMustHaveAddMethod, GetClrTypeFullName(UnderlyingType))));
                             }
-                            Debug.Assert(AddMethod != null || Kind == CollectionKind.Array, "Add method cannot be null if the collection is being used as a get-only property");
+
+                            if (Kind != CollectionKind.Array && AddMethod == null)
+                            {
+                                throw DiagnosticUtility.ExceptionUtility.ThrowHelperError(new InvalidDataContractException(SR.Format(SR.GetOnlyCollectionMustHaveAddMethod, GetClrTypeFullName(UnderlyingType))));
+                            }
+
                             XmlFormatGetOnlyCollectionReaderDelegate tempDelegate = new XmlFormatReaderGenerator().GenerateGetOnlyCollectionReader(this);
                             Interlocked.MemoryBarrier();
                             _helper.XmlFormatGetOnlyCollectionReaderDelegate = tempDelegate;

src/System.Runtime.Serialization.Json/tests/ReflectionOnly/Resources/System.Runtime.Serialization.Json.ReflectionOnly.Tests.rd.xml

@@ -21,8 +21,5 @@
     <Compile Include="$(TestSourceFolder)..\DataContractJsonSerializer.CoreCLR.cs" />
     <Compile Include="$(TestSourceFolder)..\..\..\System.Runtime.Serialization.Xml\tests\SerializationTypes.CoreCLR.cs" />
   </ItemGroup>
-  <ItemGroup Condition="'$(TargetGroup)' == 'uap'">
-    <EmbeddedResource Include="$(MsBuildThisFileDirectory)Resources\$(AssemblyName).rd.xml" />
-  </ItemGroup>
   <Import Project="$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory), dir.targets))\dir.targets" />
 </Project>

src/System.Runtime.Serialization.Json/tests/ReflectionOnly/System.Runtime.Serialization.Json.ReflectionOnly.Tests.csproj

@@ -37,8 +37,5 @@
     <Compile Include="$(TestSourceFolder)..\SerializationTypes.CoreCLR.cs" />
     <Compile Include="$(TestSourceFolder)..\DataContractSerializer.CoreCLR.cs" />
   </ItemGroup>
-  <ItemGroup Condition="'$(TargetGroup)' == 'uap'">
-    <EmbeddedResource Include="$(MsBuildThisFileDirectory)Resources\$(AssemblyName).rd.xml" />
-  </ItemGroup>
   <Import Project="$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory), dir.targets))\dir.targets" />
 </Project>